Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix risk of unfinished span when panic occurred in http handler #46

Open
njspok opened this issue Jun 18, 2019 · 0 comments
Open

Fix risk of unfinished span when panic occurred in http handler #46

njspok opened this issue Jun 18, 2019 · 0 comments

Comments

@njspok
Copy link

njspok commented Jun 18, 2019

Last fixes 2b2d270#diff-3fde75a8887529bd00893a052634c273 require in handler h(sct.wrappedResponseWriter(), r) call WriteHeader. If not call WriteHeader defer mark span as error.

I use echo http server and dont call WriteHeader in my handlers - echo server alone make this call. In result all my spans in this middleware marked as errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njspok