Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "net/rpc" and database/sql support during GSoC 2017 #8

Open
starsdeep opened this issue Feb 4, 2017 · 6 comments
Open

Add "net/rpc" and database/sql support during GSoC 2017 #8

starsdeep opened this issue Feb 4, 2017 · 6 comments

Comments

@starsdeep
Copy link

Currently, instrumentation is just provided for net/http. Instrumentation for net/rpc and database/sqlseems also worth doing.

I am a master who want to apply GSoC 2017, I 'd like to implement the instrumentation for net/rpc or database/sql as my GSoC project.

cc @pritianka

@starsdeep
Copy link
Author

ref opentracing/opentracing-go#132

@starsdeep starsdeep changed the title Add "net/rpc" support during GSoC 2017 Add "net/rpc" and database/sql support during GSoC 2017 Feb 4, 2017
@bhs
Copy link
Contributor

bhs commented Feb 4, 2017

Naively, I'd vote for database/sql over net/http for sure. That said, the problem with the database package is that there's no support for Go Context, and thus it's almost impossible to find a parent SpanContext.

@noxiouz
Copy link

noxiouz commented Feb 4, 2017

Since 1.8 it supports

@bhs
Copy link
Contributor

bhs commented Feb 4, 2017

@noxiouz ah, that's great. I was looking at https://golang.org/pkg/database/sql/ and forgot it's still 1.7. In that case, database/sql SGTM. :)

@zhouheng92
Copy link

IMOnet/http/cgi and net/http/fcgi instrumentation is also worth doing. A lot of existing system still use CGI.

@starsdeep
Copy link
Author

Will OpenTracing participate GSoC this year? Seem there is no OpenTracing related ideas in the cncf ideas list for GSoC 2018(see https:/cncf/soc)

cc @pritianka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants