Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep interface clean #60

Open
sydneyhenrard opened this issue Aug 24, 2019 · 2 comments
Open

Keep interface clean #60

sydneyhenrard opened this issue Aug 24, 2019 · 2 comments

Comments

@sydneyhenrard
Copy link

I noticed that several interfaces have anonymous implementation in it.

  • STANDARD_TAGS in ServletFilterSpanDecorator
  • STANDARD_LOGS in HandlerInterceptorSpanDecorator
  • HANDLER_METHOD_OPERATION_NAME in HandlerInterceptorSpanDecorator

Is there a reason?

I wanted to add queryString to Tags.HTTP_URL but since I can't extend STANDARD_TAGS, I have to create my own class and copy paste all methods and change what I need. If I could extend the class, I could have just override onRequest.

@pavolloffay
Copy link
Collaborator

There is no reason. We could provide a class which can be overridden.

@pavolloffay
Copy link
Collaborator

Are you willing to submit a PR. I would like to keep the constants to be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants