Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluld-1.1.1 fails to build #15807

Closed
ByteEnable opened this issue Jun 8, 2021 · 4 comments · Fixed by #15820
Closed

bluld-1.1.1 fails to build #15807

ByteEnable opened this issue Jun 8, 2021 · 4 comments · Fixed by #15820

Comments

@ByteEnable
Copy link

ByteEnable commented Jun 8, 2021

openwrt

Description:

make[6]: Entering directory '/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1'
[ 11%] Building CXX object CMakeFiles/bluld.dir/blinkstick-userspace-led-daemon/src/LEDBinding.cpp.o
/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1/blinkstick-userspace-led-daemon/src/LEDBinding.cpp: In member function 'void BlinkstickUserspace::LEDBinding::registerUserSpaceLED()':
/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1/blinkstick-userspace-led-daemon/src/LEDBinding.cpp:57:10: error: 'char* strncpy(char*, const char*, size_t)' specified bound 64 equals destination size [-Werror=stringop-truncation]
   strncpy(dev.name, mName.c_str(), LED_MAX_NAME_SIZE);
   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[6]: *** [CMakeFiles/bluld.dir/build.make:95: CMakeFiles/bluld.dir/blinkstick-userspace-led-daemon/src/LEDBinding.cpp.o] Error 1
make[6]: Leaving directory '/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1'
make[5]: *** [CMakeFiles/Makefile2:95: CMakeFiles/bluld.dir/all] Error 2
make[5]: Leaving directory '/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1'
make[4]: *** [Makefile:149: all] Error 2
make[4]: Leaving directory '/home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1'
make[3]: *** [Makefile:50: /home/ByteEnable/temp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/bluld-1.1.1/.built] Error 2
make[3]: Leaving directory '/home/ByteEnable/temp/openwrt/feeds/packages/utils/bluld'
time: package/feeds/packages/bluld/compile#0.41#0.07#0.47
    ERROR: package/feeds/packages/bluld failed to build.
make[2]: *** [package/Makefile:116: package/feeds/packages/bluld/compile] Error 1
make[2]: Leaving directory '/home/ByteEnable/temp/openwrt'
make[1]: *** [package/Makefile:110: /home/ByteEnable/temp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/stamp/.package_compile] Error 2
make[1]: Leaving directory '/home/ByteEnable/temp/openwrt'
make: *** [/home/ByteEnable/temp/openwrt/include/toplevel.mk:230: world] Error 2
@neheb
Copy link
Contributor

neheb commented Jun 8, 2021

report it here: https:/ktgeek/bluld/issues

@neheb
Copy link
Contributor

neheb commented Jun 8, 2021

quick way to fix is to replace

LED_MAX_NAME_SIZE

with

LED_MAX_NAME_SIZE - 1

@neheb
Copy link
Contributor

neheb commented Jun 8, 2021

oh @ktgeek is active here.

@ktgeek
Copy link
Contributor

ktgeek commented Jun 10, 2021

oh man, facepalm to that coding error. I wonder why that hasn't showed up for me before. I must not have -Werror=stringop-truncation.

I'll get that fixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants