miredo: Initial import of the package #4201

ppetr · 2017-03-26T09:50:56Z

Maintainer: me
Compile tested: OpenWrt-SDK-15.05.1-brcm47xx-mips74k_gcc-4.8-linaro_uClibc-0.9.33.2.Linux-x86_64
Run tested: ASUS RT-N66U (brcm47xx-mips74k) running Chaos Calmer (15.05.1, r48532); works and provides IPv6 connectivity behind NAT as expected out of the box.

Description:
Miredo is an open-source Teredo IPv6 tunneling software, for Linux and the BSD operating systems. It includes functional implementations of all components of the Teredo specification (client, relay and server). It is meant to provide IPv6 connectivity even from behind NAT devices.

diizzyy

Please review these suggestions

diizzyy · 2017-03-26T11:41:52Z

ipv6/miredo/Makefile

@@ -0,0 +1,65 @@
+#
+# Copyright (C) 2006-2017 OpenWrt.org


Do not assign copyright to OpenWrt unless you affiliated.

OK, I probably misunderstood

An up-to-date copyright notice. Use OpenWrt if no other present or supply your own.

in the Contribution Guidelines. I don't really care for copyright, so I'm happy to have none, but I can put there whatever is preferred, or create my own.

To be clear, you're free to add your own however :-)

Added my own, pro forma :)

diizzyy · 2017-03-26T11:42:11Z

ipv6/miredo/Makefile

+PKG_VERSION:=1.2.6
+PKG_RELEASE:=1
+
+PKG_BUILD_DIR:=$(BUILD_DIR)/miredo-$(PKG_VERSION)


Not needed?

diizzyy · 2017-03-26T11:42:28Z

ipv6/miredo/Makefile

+PKG_BUILD_DIR:=$(BUILD_DIR)/miredo-$(PKG_VERSION)
+PKG_SOURCE:=miredo-1.2.6.tar.xz
+PKG_SOURCE_URL:=https://www.remlab.net/files/miredo/
+PKG_SHA256SUM:=fa26d2f4a405415833669e2e2e22677b225d8f83600844645d5683535ea43149


Should be PKG_HASH

diizzyy · 2017-03-26T11:42:40Z

ipv6/miredo/Makefile

+PKG_SOURCE:=miredo-1.2.6.tar.xz
+PKG_SOURCE_URL:=https://www.remlab.net/files/miredo/
+PKG_SHA256SUM:=fa26d2f4a405415833669e2e2e22677b225d8f83600844645d5683535ea43149
+PKG_CAT:=xzcat


diizzyy · 2017-03-26T11:45:05Z

ipv6/miredo/Makefile

+
+CONFIGURE_VARS += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
+
+define Build/Configure


CONFIGURE_ARGS doesn't work?
Also, we most likely do not want a static binary rather a shared one.

Works, thank you.

I was struggling a bit with shared libraries as libtool creates wrappers instead of the actual programs. But pulling the original ones from its helper directories like src/.libs/miredo works, I updated the patch to do this. (Maybe there's a better way, I'll keep looking.) However, when using shared libraries, the package is actually larger than when using static builds. In that case, is it still worth using shared, considering that it's very unlikely another program will ever use the libraries?

Please disregard the comment about libtool, this is properly fixed by copying files created by make install. Still I'm curious if a smaller, static version won't be more efficient.

CONFIGURE_ARGS work and now I'm using shared libraries.

diizzyy · 2017-03-26T11:47:53Z

ipv6/miredo/Makefile

+ IPv6 connectivity even from behind NAT devices.
+endef
+
+CONFIGURE_VARS += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"


You probably want PKG_FIXUP:=autoreconf and TARGET_CFLAGS like here:
https:/openwrt/packages/blob/master/libs/libx264/Makefile#L27

TARGET_CFLAGS works nicely, but autoreconf doesn't. The problem is that I need to patch configure to omit some test that fails to build in the build environment (see patches/100-cross-compile.patch), but I couldn't find a way of doing this after running autoreconf.

In particular, I'm fixing configure to prevent the error below, I didn't find a better solution.

configure: checking required libraries...
checking for /proc/self/maps... configure: error: cannot check for file existence when cross compiling

Just omit it?

Omited autoreconf, kept TARGET_CFLAGS, this works now.

ppetr · 2017-03-28T07:43:50Z

PTAL?

hauke · 2017-06-05T13:54:22Z

ipv6/miredo/Makefile

+include $(INCLUDE_DIR)/package.mk
+
+CONFIGURE_ARGS+=--with-pic --without-libiconv-prefix --without-libintl-prefix --without-Judy
+TARGET_CFLAGS+=-std=gnu99 -O3 -ffast-math


Why is -O3 and -ffast-math needed here? If it is a performance optimization please add some numbers to the comments or explain why this is good.

Removed. I copied it from some other package when creating this one, probably not needed at all.

hauke · 2017-06-05T13:54:47Z

ipv6/miredo/files/miredo.init

+ procd_set_param file $CONFFILE
+ procd_set_param stdout 1 # forward stdout of the command to logd
+ procd_set_param stderr 1 # same for stderr
+ #procd_set_param user nobody # run service as user nobody


Please remove this useless commented line.

hauke · 2017-06-05T13:55:49Z

ipv6/miredo/patches/101-client-hook.patch

+
+ # Linux iproute2 path:
+-IP="/sbin/ip"
+IP="/usr/sbin/ip"


Could you make it use ip without an absolute path here or does the application does not have the PATH when executing this?

I checked, but absolute path is required here.
(Using a relative one would probably be a potential security issue anyway.)

ppetr · 2018-01-06T15:47:44Z

PTAL?
(Sorry for the long delay.)

Signed-off-by: Petr Pudlak <[email protected]>

Baozisoftware · 2018-08-02T08:03:43Z

This package on openwrt 18.06 can't be compiled in musl, but it can be compiled with glibc or uclibc(use
DEPENDS:=+libpthread +librt +ip ~~+kmod-ipv6~~ +kmod-tun +libcap
CONFIGURE_ARGS+=--with-pic --without-libiconv-prefix --without-libintl-prefix --without-Judy --enable-shared --disable-binreloc
TARGET_CFLAGS+=-**std=gnu99 -O3 -ffast-math -Wno-error=format-security

patches are redundant!
). But it only allows the router itself to access IPv6. Other devices can't.

diizzyy · 2018-12-30T11:59:35Z

@thess @hnyman
Close due to submitter timeout?

thess · 2019-01-01T18:47:10Z

Old PR being closed for lack of interest.

ppetr · 2019-01-01T20:43:14Z

My apologies to everyone involved, I haven't had any time to work on this. Should this improve, I'll fix the problems above and reopen. Thank you!

Ykidia · 2020-02-09T15:09:58Z

Hello! What about continuing? I tried to build miredo (with all modifications from here plus replaced gettext.h with newer one) against musl, but with no success. Can you help me? Thanks!

wosk · 2020-03-15T02:48:32Z

@Ykidia See following pull request

Ykidia · 2020-03-15T20:41:11Z

Thank you, but I already adopted miredo package for actual (latest in OpenWrt) gettext, modified all *.m4 (recompiling aclocal.m4), applied https:/ppetr/openwrt-miredo/pull/4 and it is compiling and working now very good. Fixing errors like in #11467 ("pass PKG_CHECK_FORMAT_SECURITY:=0") is not the way I like (and many others).
If you want, I can send full source *.tar.gz (with my changes) for you to consider to make another PR without mentioned hack.
Thank you for revival!

diizzyy requested changes Mar 26, 2017

View reviewed changes

ppetr force-pushed the add-miredo branch 2 times, most recently from 28a037c to cccb636 Compare March 26, 2017 16:24

hauke requested changes Jun 5, 2017

View reviewed changes

champtar added the New package label Jul 15, 2017

champtar closed this Aug 18, 2017

champtar reopened this Aug 18, 2017

ppetr force-pushed the add-miredo branch from cccb636 to 2d6c731 Compare January 6, 2018 15:46

ppetr force-pushed the add-miredo branch from 2d6c731 to ceff4ce Compare January 6, 2018 18:07

miredo: Initial import of the package

ceff4ce

Signed-off-by: Petr Pudlak <[email protected]>

thess closed this Jan 1, 2019

This was referenced Feb 29, 2020

miredo: Initial version 1.2.6 openwrt/openwrt#2795

Closed

miredo: Initial version 1.2.6 #11467

Merged


		CONFIGURE_VARS += CFLAGS="$(TARGET_CFLAGS) -std=gnu99"

		define Build/Configure

miredo: Initial import of the package #4201

miredo: Initial import of the package #4201

Conversation

ppetr commented Mar 26, 2017

diizzyy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppetr commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppetr commented Jan 6, 2018

Baozisoftware commented Aug 2, 2018

diizzyy commented Dec 30, 2018

thess commented Jan 1, 2019

ppetr commented Jan 1, 2019

Ykidia commented Feb 9, 2020

wosk commented Mar 15, 2020

Ykidia commented Mar 15, 2020