Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create abspath dir in case that contents is empty #2164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: create abspath dir in case that contents is empty #2164

wants to merge 1 commit into from

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

fix bug of issue 2133

Which issue(s) this PR fixes:

Fixes #2133

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.91%. Comparing base (3713163) to head (e803427).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurthub/storage/disk/storage.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   56.09%   58.91%   +2.81%     
==========================================
  Files         186      210      +24     
  Lines       18092    18970     +878     
==========================================
+ Hits        10149    11176    +1027     
+ Misses       6910     6711     -199     
- Partials     1033     1083      +50
Flag Coverage Δ
unittests 58.91% <0.00%> (+2.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@vie-serendipity would you like to post a pull request to fix Trivy Scan error. you can check the error Details and find the error reason.

@vie-serendipity
Copy link
Contributor Author

@rambohe-ch ok

@vie-serendipity
Copy link
Contributor Author

/rerun

@vie-serendipity
Copy link
Contributor Author

It looks like the download of the vulnerability database failed due to some network issues. But after I tried again, everything is working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vie-serendipity @rambohe-ch