Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type of stream_file in download.py is incorrect #104

Closed
benoit74 opened this issue Jul 13, 2023 · 0 comments · Fixed by #105
Closed

Return type of stream_file in download.py is incorrect #104

benoit74 opened this issue Jul 13, 2023 · 0 comments · Fixed by #105
Assignees
@benoit74
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@benoit74
Copy link
Collaborator

Return type of stream_file in download.py is incorrect

python-scraperlib/src/zimscraperlib/download.py

Line 177 in 36ae903

) -> Union[int, requests.structures.CaseInsensitiveDict]:

It is an Union while it should by a Tuple
@benoit74 benoit74 added the bug Something isn't working label Jul 13, 2023
@benoit74 benoit74 self-assigned this Jul 13, 2023
@rgaudin rgaudin added the good first issue Good for newcomers label Jul 13, 2023
@benoit74 benoit74 mentioned this issue Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit74 benoit74

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return type since it is a Tuple and not a Union openzim/python-scraperlib
2 participants
@rgaudin @benoit74