Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creator.add_item_for content param hint is incorrect #107

Closed
rgaudin opened this issue Jul 18, 2023 · 0 comments · Fixed by #108
Closed

Creator.add_item_for content param hint is incorrect #107

rgaudin opened this issue Jul 18, 2023 · 0 comments · Fixed by #108
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
3.1.1

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 18, 2023

zim.creator.Creator.add_item_for() accepts a content param declared as content: Optional[bytes] = None.

This is wrong as it also accepts str… and is used mostly using it.
@rgaudin rgaudin added bug Something isn't working good first issue Good for newcomers labels Jul 18, 2023
AmirAflak added a commit to AmirAflak/python-scraperlib that referenced this issue Jul 18, 2023
@AmirAflak
fix: openzim#107 to handle string type
23da5ce
@kelson42 kelson42 mentioned this issue Jul 18, 2023
Merged
@rgaudin rgaudin mentioned this issue Jul 18, 2023
Merged
rgaudin added a commit that referenced this issue Jul 18, 2023
@rgaudin
Merge pull request #108 from AmirAflak/patch-1
7453f06 
fix: #107 to handle string type
@kelson42 kelson42 added this to the 3.2.0 milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

Creator.add_item_for content param hint AmirAflak/python-scraperlib
2 participants
@rgaudin @kelson42