Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependencies for pip's new dep resolver #52

Closed
rgaudin opened this issue Aug 24, 2020 · 9 comments
Closed

Check dependencies for pip's new dep resolver #52

rgaudin opened this issue Aug 24, 2020 · 9 comments
Assignees
Labels
duplicate This issue or pull request already exists good first issue Good for newcomers
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Aug 24, 2020

In October 2020, the new dependency resolver for pip will replace the current one (in pip 20.3). We'll still have the ability to use the old one until pip 21.1.

We should ensure that all our Python scrapers can still be installed with the new dependencies resolver ; especially the ones we are not actively working on as this resolver-change will be long-forgotten when we'll come back to those in a late future.

See list of scrapers.

@rgaudin rgaudin added the scrapers Applies to all scrapers label Aug 24, 2020
@kelson42 kelson42 pinned this issue Sep 4, 2020
@kelson42 kelson42 added the good first issue Good for newcomers label Sep 4, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 5, 2020
@brainwane
Copy link

I found this issue via a GitHub search and figured I ought to mention some useful troubleshooting and workaround tips from the documentation, especially now that pip 20.3 is out and the new resolver is the default:

  • If pip is taking longer to install packages, read Dependency resolution backtracking for ways to reduce the time pip spends backtracking due to dependency conflicts.

  • If you don’t want pip to actually resolve dependencies, use the --no-deps option. This is useful when you have a set of package versions that work together in reality, even though their metadata says that they conflict. For guidance on a long-term fix, read Fixing conflicting dependencies.

  • If you run into resolution errors and need a workaround while you’re fixing their root causes, you can choose the old resolver behavior using the flag --use-deprecated=legacy-resolver. This will work until we release pip 21.0 (see Deprecation timeline).

@stale stale bot removed the stale label Dec 3, 2020
@kelson42
Copy link
Contributor

kelson42 commented Dec 4, 2020

@brainwane Hi Sumana, so nice to see you there :) Thank you for the comment, I guess @rgaudin will carry on with this ASAP.

@brainwane
Copy link

Hi @kelson42 - nice to see you again! Hope all goes well with the dependency improvements.

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@kelson42
Copy link
Contributor

@rgaudin We should probably move on this if this has not been done so far. Should we open similar tickets in other Python repos?

@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 13, 2022
@kelson42 kelson42 modified the milestones: 3.1.1, 3.2.0 Jul 18, 2023
@stale stale bot removed stale labels Jul 18, 2023
@kelson42
Copy link
Contributor

Wonder how newly created https:/openzim/_python-bootstrap impacts this ticket.

@rgaudin
Copy link
Member Author

rgaudin commented Jul 19, 2023

In itself, it doesn't but as we switch to it, it will become obsolete as we update scrapers.

Goal behind this overview ticket was to proactively test (on all scrapers) the new resolver and update dependencies accordingly at a time pip allowed both resolver to be used.
Given we already have overview ticket to update python versions, I am closing this as duplicate.

@rgaudin rgaudin closed this as completed Jul 19, 2023
@rgaudin rgaudin added duplicate This issue or pull request already exists and removed scrapers Applies to all scrapers labels Jul 19, 2023
@rgaudin rgaudin self-assigned this Jul 19, 2023
@kelson42 kelson42 unpinned this issue Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants