Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zimit2: confirm last wombat setup arguments #239

Open
benoit74 opened this issue Apr 29, 2024 · 1 comment · May be fixed by #334
Open

Zimit2: confirm last wombat setup arguments #239

benoit74 opened this issue Apr 29, 2024 · 1 comment · May be fixed by #334
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

In Wombat setup code in warc2zim2, we have few arguments which are undocumented / weird.

    enable_auto_fetch: true,
    convert_post_to_get: true,
    target_frame: '___wb_replay_top_frame',
    isSW: true,

We need to confirm whether they are correct and why

@Jaifroid
Copy link

I can't help with the other values, but target_frame: '___wb_replay_top_frame' seems like a hangover from classic Zimit, where there is an actual iframe with that identifier that contains the rendered document, and which Wombat has to be injected into (I know because I set that up more or less "manually" in the classic Zimit support in KJS). That should no longer be relevant (but I've no idea if warc2zim2 works without it...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants