Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video viewer should allow change of reading speed #174

Closed
Popolechien opened this issue Aug 9, 2023 · 6 comments · Fixed by #229
Closed

Video viewer should allow change of reading speed #174

Popolechien opened this issue Aug 9, 2023 · 6 comments · Fixed by #229
Assignees
Milestone

Comments

@Popolechien
Copy link

Many players allows their users to modify the video reading speed, either more slowly to ease comprehension or faster for speed-viewing (e.g. 0.75x - 1.25x)

@benoit74 benoit74 added this to the 2.2.0 milestone Oct 13, 2023
@benoit74 benoit74 modified the milestones: 2.2.0, 2.3.0 Nov 17, 2023
@benoit74 benoit74 modified the milestones: 2.3.0, 3.0.0 May 22, 2024
@kelson42 kelson42 pinned this issue May 22, 2024
@benoit74
Copy link
Collaborator

#229 suggests to propose 0.25, 0.5, 1, 1.5, 2 as reading speeds in ; @dan-niles could you explain why you chose these values?

@Popolechien these are the reading speed that will be available in the video player, is that ok for you?

@dan-niles
Copy link
Collaborator

I just wanted to make it more similar to what YouTube offers, ranging from 0.25x to 2x.

Additionally YouTube also provides 0.75x and 1.75x, so I can also include those if needed. So the playback rates would be: [0.25, 0.5, 0.75, 1, 1.5, 1.75, 2]

@Popolechien
Copy link
Author

7 different speeds? Seems a lot to me but who are we to question their choices ¯_(ツ)_/¯

@benoit74
Copy link
Collaborator

Then we are all OK to keep only 5 choices?

@Popolechien
Copy link
Author

Yeah Netflix has 0.5x, 0.75x, 1x, 1.25x, 1.5x (5 choices). Since #229 is in the pipe already I think it fits well enough.

@benoit74
Copy link
Collaborator

OK, so let's use 0.25, 0.5, 1, 1.5, 2 for now, and we'll see if this is a problem.

@kelson42 kelson42 unpinned this issue Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants