Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early if ZIM cannot be created at given location / name #204

Closed
benoit74 opened this issue May 21, 2024 · 1 comment · Fixed by #262
Closed

Fail early if ZIM cannot be created at given location / name #204

benoit74 opened this issue May 21, 2024 · 1 comment · Fixed by #262

Comments

@benoit74
Copy link
Collaborator

Currently, if given output location or ZIM name are incorrect, we fail very late, after all stuff has been scraped.

We should fail way earlier.

We should use openzim/python-scraperlib#163 (once implemented) for these checks.

Playlist mode where ZIM name is dynamically computed is probably going to be a bit more complex / not possible, but we will live without that (especially since anyway we do not use playlist mode in Zimfarm anymore)

@benoit74
Copy link
Collaborator Author

3.4.0 has been released, we now need to use the utility in our codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants