Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set autoplay option to always be true for videos in new UI #233

Closed
dan-niles opened this issue Jun 19, 2024 · 5 comments · Fixed by #244
Closed

Set autoplay option to always be true for videos in new UI #233

dan-niles opened this issue Jun 19, 2024 · 5 comments · Fixed by #244
Assignees
Labels
Milestone

Comments

@dan-niles
Copy link
Collaborator

With the implementation of #229, the video.js player has been configured to have autoplay set to false by default. The entrypoint.py script includes an argument called --autoplay, which allows the user to enable or disable autoplay functionality.

We need to update the scraper so that it can convey this autoplay configuration to the Vue.js UI.

@dan-niles dan-niles added the task label Jun 19, 2024
@dan-niles dan-niles self-assigned this Jun 19, 2024
@dan-niles dan-niles added this to the 3.0.0 milestone Jun 19, 2024
@Kaif9999
Copy link

Hey I wanted to contribute to this issue is it still open.

@kelson42
Copy link
Contributor

@Kaif9999 Hi, it's open but assigned to @dan-niles, maybe you can find one which is not assigned?

@Kaif9999
Copy link

Hi, also wanted to ask are there any issues I can work with I am a beginner to open source with the knowledge of Python have built a few small projects in it, I am also proficient in html, css, javascript

@benoit74
Copy link
Collaborator

@Kaif9999 youtube scraper is indeed undergoing a significant effort of rewriting, so this issue is assigned to Dan because he is the best one to tackle this issue.

Please also prefer to consider issues tagged "good first issue" and not assigned to someone (or without activity by this person for months) preferably. Preferably because it is ok to ask for contributing on issues not matching these criteria, but the chances we say "no" are higher obviously ^^

More information on how to contribute at www.kiwix.org/code

@dan-niles dan-niles changed the title Set autoplay option for videos in new UI Set autoplay option to always be true for videos in new UI Jun 25, 2024
@dan-niles
Copy link
Collaborator Author

dan-niles commented Jun 25, 2024

In #237 we decided to remove the --autoplay CLI argument and set autoplay: true always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants