Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge behaviors of user/channel types and add support for forHandle #339

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #338 (and make life easier for everyone)

Rationale:

  • it is cumbersome for the end-user to try both channel and user types, there is no way to know in advance which one is correct
  • it is easy to programmatically test both parameters one after the other one, there is probably no conflict possible
  • since early 2024, Youtube API supports a new forHandle parameter which is probably the one we always want to use (but we have recipes which might still be configured by technical ID, so let's keep previous criteria as a fallback)
  • I do not want to wait for a major release to drop --type user so for now I left it as accepted but merge behavior, and a warning is displayed about the fact that this is a deprecated value

@benoit74 benoit74 self-assigned this Sep 20, 2024
@benoit74 benoit74 force-pushed the merge_user_channel branch 2 times, most recently from 7fbfd0a to 2fbde43 Compare September 20, 2024 20:26
@benoit74 benoit74 added this to the 3.2.0 milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 1.51%. Comparing base (dfcf7ae) to head (b138fff).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/youtube.py 0.00% 15 Missing ⚠️
scraper/src/youtube2zim/scraper.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #339      +/-   ##
========================================
- Coverage   1.52%   1.51%   -0.01%     
========================================
  Files         11      11              
  Lines       1118    1119       +1     
  Branches     168     170       +2     
========================================
  Hits          17      17              
- Misses      1101    1102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit b0015c9 into main Sep 24, 2024
10 checks passed
@benoit74 benoit74 deleted the merge_user_channel branch September 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to scrape channel Quickguidesformedicine
2 participants