Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless 'format' setting when download thumbnails and subtitles #354

Closed
wants to merge 1 commit into from

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 7, 2024

Fix #351

Changes:

  • do not pass the format option to yt_dlp when downloading thumbnails or subtitles, this makes the download fail
  • add debug log when thumbnail or subtitle download succeeded

@benoit74 benoit74 self-assigned this Oct 7, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Oct 7, 2024

This is not really the solution, just a random way to partially fix the real issue.

@benoit74 benoit74 closed this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 1.51%. Comparing base (b0015c9) to head (e4a27a9).

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #354      +/-   ##
========================================
- Coverage   1.51%   1.51%   -0.01%     
========================================
  Files         11      11              
  Lines       1119    1123       +4     
  Branches     170     170              
========================================
  Hits          17      17              
- Misses      1102    1106       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 deleted the fix_thumb_sub_dl branch October 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipes failing due to format not found
1 participant