Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when editor is changing a recipe warehouse path #951

Open
benoit74 opened this issue Apr 15, 2024 · 2 comments
Open

Add warning when editor is changing a recipe warehouse path #951

benoit74 opened this issue Apr 15, 2024 · 2 comments

Comments

@benoit74
Copy link
Collaborator

When the user is changing the warehouse path of a recipe which already produced a ZIM, Zimfarm will display a warning like "Changing the warehouse path of a recipe is not a minor change. You need to first move all existing ZIMs to the new target warehouse path."

This could help to avoid issues like kiwix/operations#181

Not sure it is easy to detect if the recipe already produced a ZIM, if it is too cumbersome we can display the warning whenever the recipe already succeeded once. It is is too cumbersome, we can display the warning whenever the user is changing the warehouse path.

@Popolechien @RavanJAltaie @kelson42 @rgaudin does it make sense to you? Any better wording to propose?

@rgaudin
Copy link
Member

rgaudin commented Apr 15, 2024

Let's try this. If it's too annoying, we'll revert.

@RavanJAltaie
Copy link

Let's try this. If it's too annoying, we'll revert.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants