-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External links should not be clickable #374
Labels
Comments
Once again, I advocate for a general decision turned into a documented behavior/policy. FFT:
|
We need a general decision on this, based on a live discussions of pros and cons.
I suspect you meant "all readers"? |
Yes :) |
Well depending on the solution it could be both |
This is a duplicate of openzim/warc2zim#65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I remember having this discussion before but I can't find any past issue putting this is writing.
Each website that we scrape has a number of links going to external resources that will not be scraped (for a good example try https://library.kiwix.org/viewer#lua.org_en_all/www.lua.org/about.html) - when truly offline, these links return an error message.
Unless they are extremely careful (and not on a mobile device), users have no way of knowing in advance that clicking on a link will lead them nowhere. Considering our primary use case accounts for no connectivity whatsover, this leads to poor UX and should be prevented.
MWoffliner already has such a behaviour that red links (or internal links in the case of a subset) are turned to regular text. I believe this should also be the case here.
The text was updated successfully, but these errors were encountered: