Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links should not be clickable #374

Open
Popolechien opened this issue Aug 22, 2024 · 5 comments
Open

External links should not be clickable #374

Popolechien opened this issue Aug 22, 2024 · 5 comments

Comments

@Popolechien
Copy link
Contributor

I remember having this discussion before but I can't find any past issue putting this is writing.

Each website that we scrape has a number of links going to external resources that will not be scraped (for a good example try https://library.kiwix.org/viewer#lua.org_en_all/www.lua.org/about.html) - when truly offline, these links return an error message.

Unless they are extremely careful (and not on a mobile device), users have no way of knowing in advance that clicking on a link will lead them nowhere. Considering our primary use case accounts for no connectivity whatsover, this leads to poor UX and should be prevented.

MWoffliner already has such a behaviour that red links (or internal links in the case of a subset) are turned to regular text. I believe this should also be the case here.

@rgaudin
Copy link
Member

rgaudin commented Aug 22, 2024

Once again, I advocate for a general decision turned into a documented behavior/policy.

FFT:

  • There's meaning in something being a link (whether or not you can access it).
  • wikipedia has this concept of external links (via an icon) that's very practical. We've copied it on some scrapers (sotoki at least)
  • it would be fragile to implement such a change to a generic scraper like zimit because we don't control the rendering at all.
  • we have an external link blocker in kiwix-serve. this could be implemented in all scrapers.

@benoit74
Copy link
Collaborator

benoit74 commented Sep 2, 2024

We need a general decision on this, based on a live discussions of pros and cons.

we have an external link blocker in kiwix-serve. this could be implemented in all scrapers.

I suspect you meant "all readers"?

@rgaudin
Copy link
Member

rgaudin commented Sep 2, 2024

Yes :)

@rgaudin
Copy link
Member

rgaudin commented Sep 2, 2024

Well depending on the solution it could be both

@kelson42
Copy link
Contributor

kelson42 commented Oct 2, 2024

This is a duplicate of openzim/warc2zim#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants