Makes constant endpoint an api with implementations available #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
changed the title
added 2 commits
February 14, 2024 08:34
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Feb 14, 2024
reta
approved these changes
Feb 14, 2024
|
Looks pretty clean! 🥇 |
|
glad you like it, missing rate limiter coming in a minute. This is important as eureka isn't designed to respond fast (at least I notice some latency). We also need it to rate limit when there are errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a former change @anuraaga rightly mentioned that there is trouble putting concrete types in the HttpSupplier interface file. I noticed spring has its own type they use as a constant supplier,
ZipkinConnectionDetails. Since this is an interface, this double-underscores the same concern.This hopefully clears up the topic, as well making a place to implement a rate-limited supplier, something sleuth has, but boot doesn't yet.