feat(controller): Create GitHub check for taskRuns #146

SamoKopecky · 2022-06-17T09:32:57Z

Resolves #63
Resolves #51

A GitHub check is created whenever a taskRun is created. The user can then re-run the task via the check re-run button. The checks are created only if the push contains a change in peribolos.yaml config, if more commits are pushed at the same time the check runs only on the most recent commit.

sesheta · 2022-06-17T09:33:13Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tumido

Quick review, I think we're not heading in the right direction with this. We should not be blocking the controller and keeping it occupied while Tekton is processing a task.

src/app.ts

tumido · 2022-06-21T10:38:48Z

Btw, those issues created by a failed workflow, I love it! Those log snippets are great! 👍 💯

SamoKopecky · 2022-06-23T07:45:23Z

/cc @tumido

tumido

Great progress, I like it, there are some little things to fix but overall I like this.

src/app.ts

SamoKopecky · 2022-06-27T15:10:30Z

Updated with a pushed commit.
/cc @tumido

Example of as skipped check_run:

https:/skopecky-test/.github/runs/7074303895

src/app.ts

SamoKopecky · 2022-06-28T15:58:09Z

New changes were pushed. Ready for review again!

tumido

Great! We're getting there! 🙂 I have one small nit for you, otherwise lgtm 👍

src/app.ts

SamoKopecky · 2022-06-30T09:21:10Z

Thanks for the great feedback Tom, ready for review.

I think we should wait for #156 to merge since we are migrating the tasks to the new secret name. I can then rebase my branch to the upstream and rename this secret reference too.

tumido

Last issue, I promise 😄 🤞

src/app.ts

SamoKopecky · 2022-06-30T09:40:08Z

/hold
Waiting for #156 to merge.

Signed-off-by: SamoKopecky <[email protected]>

SamoKopecky · 2022-06-30T09:46:47Z

/unhold
Rebased to upstream and referencing the correct secret in run task.

tumido

/lgtm
/approve

sesheta · 2022-06-30T10:05:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tumido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# [1.2.0](v1.1.0...v1.2.0) (2022-07-07) ### Bug Fixes * **tasks:** Reference the correct secret ([abb2957](abb2957)) ### Features * **controller:** Create GitHub check for taskRuns ([#146](#146)) ([24b25e9](24b25e9)) ### Reverts * Reset dev overlay to base ([3b503ec](3b503ec))

github-actions · 2022-07-07T09:56:44Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2022

sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2022

sesheta requested review from KPostOffice and tumido June 17, 2022 09:33

SamoKopecky force-pushed the create-issue-on-task-fail branch from 4a72dac to a9229ce Compare June 20, 2022 10:49

SamoKopecky marked this pull request as ready for review June 20, 2022 10:51

sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2022

SamoKopecky changed the title ~~feat(controller): Add issue creation on taskRun fail~~ feat(controller): Create issue on taskRun fail Jun 20, 2022

SamoKopecky changed the title ~~feat(controller): Create issue on taskRun fail~~ feat(controller): Create issue on taskRun fail and re-run capability Jun 20, 2022

SamoKopecky changed the title ~~feat(controller): Create issue on taskRun fail and re-run capability~~ feat(controller): Create issue on taskRun fail and add re-run capability Jun 20, 2022

SamoKopecky force-pushed the create-issue-on-task-fail branch 2 times, most recently from 1e115c1 to b02a0b0 Compare June 20, 2022 15:08

tumido requested changes Jun 20, 2022

View reviewed changes

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

SamoKopecky force-pushed the create-issue-on-task-fail branch from b02a0b0 to 514464c Compare June 23, 2022 07:43

SamoKopecky changed the title ~~feat(controller): Create issue on taskRun fail and add re-run capability~~ feat(controller): Create GitHub check on taskRuns Jun 23, 2022

SamoKopecky changed the title ~~feat(controller): Create GitHub check on taskRuns~~ feat(controller): Create GitHub check for taskRuns Jun 23, 2022

sesheta requested a review from tumido June 23, 2022 07:45

SamoKopecky force-pushed the create-issue-on-task-fail branch from 514464c to d42a994 Compare June 23, 2022 07:50

tumido requested changes Jun 27, 2022

View reviewed changes

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Show resolved Hide resolved

SamoKopecky force-pushed the create-issue-on-task-fail branch from 106508a to aaca262 Compare June 27, 2022 15:06

SamoKopecky requested a review from tumido June 27, 2022 15:10

tumido requested changes Jun 28, 2022

View reviewed changes

src/app.ts Outdated Show resolved Hide resolved

src/app.ts Outdated Show resolved Hide resolved

SamoKopecky force-pushed the create-issue-on-task-fail branch from aaca262 to 40d54c3 Compare June 28, 2022 15:55

SamoKopecky requested a review from tumido June 28, 2022 15:57

SamoKopecky force-pushed the create-issue-on-task-fail branch from 40d54c3 to 64b8138 Compare June 28, 2022 21:21

tumido requested changes Jun 30, 2022

View reviewed changes

src/app.ts Outdated Show resolved Hide resolved

SamoKopecky force-pushed the create-issue-on-task-fail branch 2 times, most recently from cd26b9e to 2dc3e04 Compare June 30, 2022 09:19

SamoKopecky requested a review from tumido June 30, 2022 09:21

tumido requested changes Jun 30, 2022

View reviewed changes

src/app.ts Outdated Show resolved Hide resolved

SamoKopecky force-pushed the create-issue-on-task-fail branch from 2dc3e04 to d52e1d2 Compare June 30, 2022 09:38

SamoKopecky requested a review from tumido June 30, 2022 09:39

sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022

SamoKopecky added 2 commits June 30, 2022 11:45

feat(controller): Create GitHub chceks for taskRuns

f834cd8

Signed-off-by: SamoKopecky <[email protected]>

fix(peribolos-run): Use the correct repo remote

7285f83

Signed-off-by: SamoKopecky <[email protected]>

SamoKopecky force-pushed the create-issue-on-task-fail branch from d52e1d2 to 7285f83 Compare June 30, 2022 09:45

sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022

tumido approved these changes Jun 30, 2022

View reviewed changes

sesheta assigned tumido Jun 30, 2022

sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022

sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022

sesheta merged commit 24b25e9 into operate-first:main Jun 30, 2022

github-actions bot added the released Marks issues as released label Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controller): Create GitHub check for taskRuns #146

feat(controller): Create GitHub check for taskRuns #146

SamoKopecky commented Jun 17, 2022 •

edited

Loading

sesheta commented Jun 17, 2022

tumido left a comment

tumido commented Jun 21, 2022

SamoKopecky commented Jun 23, 2022

tumido left a comment

SamoKopecky commented Jun 27, 2022 •

edited

Loading

SamoKopecky commented Jun 28, 2022

tumido left a comment

SamoKopecky commented Jun 30, 2022 •

edited

Loading

tumido left a comment

SamoKopecky commented Jun 30, 2022

SamoKopecky commented Jun 30, 2022

tumido left a comment

sesheta commented Jun 30, 2022

github-actions bot commented Jul 7, 2022

feat(controller): Create GitHub check for taskRuns #146

feat(controller): Create GitHub check for taskRuns #146

Conversation

SamoKopecky commented Jun 17, 2022 • edited Loading

sesheta commented Jun 17, 2022

tumido left a comment

Choose a reason for hiding this comment

tumido commented Jun 21, 2022

SamoKopecky commented Jun 23, 2022

tumido left a comment

Choose a reason for hiding this comment

SamoKopecky commented Jun 27, 2022 • edited Loading

SamoKopecky commented Jun 28, 2022

tumido left a comment

Choose a reason for hiding this comment

SamoKopecky commented Jun 30, 2022 • edited Loading

tumido left a comment

Choose a reason for hiding this comment

SamoKopecky commented Jun 30, 2022

SamoKopecky commented Jun 30, 2022

tumido left a comment

Choose a reason for hiding this comment

sesheta commented Jun 30, 2022

github-actions bot commented Jul 7, 2022

SamoKopecky commented Jun 17, 2022 •

edited

Loading

SamoKopecky commented Jun 27, 2022 •

edited

Loading

SamoKopecky commented Jun 30, 2022 •

edited

Loading