[44481]Expandable Enterprise Edition banners #11503
Conversation
| <op-icon icon-classes="button--icon icon-medal"></op-icon> | ||
| <span [textContent]="text.enterpriseFeature"></span> | ||
| <div class="op-enterprise-banner--header"> | ||
| <op-icon icon-classes="button--icon icon-medal"></op-icon> |
There was a problem hiding this comment.
always use spot icons from now on
| <op-icon icon-classes="button--icon icon-medal"></op-icon> | |
| <span class="spot-icon spot-icon_medal"></span> |
| > | ||
| <span class="icon1" | ||
| [ngClass]="collapsed ? 'icon-arrow-down1' : 'icon-arrow-up1'" | ||
| aria-hidden="true"> |
There was a problem hiding this comment.
Same goes for thsi one, of course
| this.collapsed = this.collapsible; | ||
| } | ||
|
|
||
| collapse():void { |
There was a problem hiding this comment.
I'd call this toggleCollapse or something since it works both ways.
…d wp form configurations
|
Hi @marcalcobe, I replaced the new extendible EE banner with the previous one in any places that I thought it would look better, Could you please let me know if any change was not necessary and should be reverted? Or is there any place missing? 1- WP table view configuration: 2- WP settings for highlighting: 3- WP filters: 4- Boards filter: 5- Projects settings: 6- New status definition in WP settings: 7- Multi-select custom fields: 8- WP form configurations: 9- Custom fields for WPs: 10- Custom fields for projects: 11- Add widget modal: |
|
Hi @bsatarnejad, sorry for the late response. I would suggest to not make it expandable in this cases as it is not really taking space from other content: 1- WP table view configuration In regards to any missing page, I only can think of the new date alerts but I think that ones are tackled in a different PR. |
Make enterprise edition banner component extendible:
There is an input named collapsible, if you set it to true while using the component anywhere it will be extendible, if you don't set any value to it, it will work as before without collapsing button.
https://community.openproject.org/projects/openproject/work_packages/44481/activity