Use ObjectReference to write events

apis/monitoring/v1alpha1/alert.go

@@ -1,6 +1,10 @@
 package v1alpha1
 
-import "time"
+import (
+ "time"
+
+ "k8s.io/apimachinery/pkg/runtime"
+)
 
 type Alert interface {
  GetName() string
@@ -11,4 +15,5 @@ type Alert interface {
  IsValid() (bool, error)
  GetNotifierSecretName() string
  GetReceivers() []Receiver
+ ObjectReference() runtime.Object
 }

apis/monitoring/v1alpha1/cluster_alert.go

@@ -3,6 +3,9 @@ package v1alpha1
 import (
  "fmt"
  "time"
+
+ "k8s.io/apimachinery/pkg/runtime"
+ apiv1 "k8s.io/client-go/pkg/api/v1"
 )
 
 const (
@@ -65,3 +68,14 @@ func (a ClusterAlert) GetNotifierSecretName() string {
 func (a ClusterAlert) GetReceivers() []Receiver {
  return a.Spec.Receivers
 }
+
+func (a ClusterAlert) ObjectReference() runtime.Object {
+ return &apiv1.ObjectReference{
+ APIVersion: SchemeGroupVersion.String(),
+ Kind: ResourceKindClusterAlert,
+ Namespace: a.Namespace,
+ Name: a.Name,
+ UID: a.UID,
+ ResourceVersion: a.ResourceVersion,
+ }
+}

apis/monitoring/v1alpha1/node_alert.go

@@ -3,6 +3,9 @@ package v1alpha1
 import (
  "fmt"
  "time"
+
+ "k8s.io/apimachinery/pkg/runtime"
+ apiv1 "k8s.io/client-go/pkg/api/v1"
 )
 
 const (
@@ -65,3 +68,14 @@ func (a NodeAlert) GetNotifierSecretName() string {
 func (a NodeAlert) GetReceivers() []Receiver {
  return a.Spec.Receivers
 }
+
+func (a NodeAlert) ObjectReference() runtime.Object {
+ return &apiv1.ObjectReference{
+ APIVersion: SchemeGroupVersion.String(),
+ Kind: ResourceKindNodeAlert,
+ Namespace: a.Namespace,
+ Name: a.Name,
+ UID: a.UID,
+ ResourceVersion: a.ResourceVersion,
+ }
+}

apis/monitoring/v1alpha1/pod_alert.go

@@ -3,6 +3,9 @@ package v1alpha1
 import (
  "fmt"
  "time"
+
+ "k8s.io/apimachinery/pkg/runtime"
+ apiv1 "k8s.io/client-go/pkg/api/v1"
 )
 
 const (
@@ -65,3 +68,14 @@ func (a PodAlert) GetNotifierSecretName() string {
 func (a PodAlert) GetReceivers() []Receiver {
  return a.Spec.Receivers
 }
+
+func (a PodAlert) ObjectReference() runtime.Object {
+ return &apiv1.ObjectReference{
+ APIVersion: SchemeGroupVersion.String(),
+ Kind: ResourceKindPodAlert,
+ Namespace: a.Namespace,
+ Name: a.Name,
+ UID: a.UID,
+ ResourceVersion: a.ResourceVersion,
+ }
+}

pkg/operator/cluster_alerts.go

@@ -37,7 +37,7 @@ func (op *Operator) WatchClusterAlerts() {
  if alert, ok := obj.(*tapi.ClusterAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToCreate,
  `Fail to be create ClusterAlert: "%v". Reason: %v`,
@@ -48,7 +48,7 @@ func (op *Operator) WatchClusterAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for ClusterAlert: "%v". Reason: %v`,
@@ -73,7 +73,7 @@ func (op *Operator) WatchClusterAlerts() {
  if !reflect.DeepEqual(oldAlert.Spec, newAlert.Spec) {
  if ok, err := newAlert.IsValid(); !ok {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be update ClusterAlert: "%v". Reason: %v`,
@@ -84,7 +84,7 @@ func (op *Operator) WatchClusterAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, newAlert); err != nil {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for ClusterAlert: "%v". Reason: %v`,
@@ -99,7 +99,7 @@ func (op *Operator) WatchClusterAlerts() {
  if alert, ok := obj.(*tapi.ClusterAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete ClusterAlert: "%v". Reason: %v`,
@@ -110,7 +110,7 @@ func (op *Operator) WatchClusterAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for ClusterAlert: "%v". Reason: %v`,
@@ -130,7 +130,7 @@ func (op *Operator) EnsureClusterAlert(old, new *tapi.ClusterAlert) (err error)
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulSync,
  `Applied ClusterAlert: "%v"`,
@@ -139,7 +139,7 @@ func (op *Operator) EnsureClusterAlert(old, new *tapi.ClusterAlert) (err error)
  return
  } else {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToSync,
  `Fail to be apply ClusterAlert: "%v". Reason: %v`,
@@ -163,7 +163,7 @@ func (op *Operator) EnsureClusterAlertDeleted(alert *tapi.ClusterAlert) (err err
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulDelete,
  `Deleted ClusterAlert: "%v"`,
@@ -172,7 +172,7 @@ func (op *Operator) EnsureClusterAlertDeleted(alert *tapi.ClusterAlert) (err err
  return
  } else {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete ClusterAlert: "%v". Reason: %v`,

pkg/operator/node_alerts.go

@@ -38,7 +38,7 @@ func (op *Operator) WatchNodeAlerts() {
  if alert, ok := obj.(*tapi.NodeAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToCreate,
  `Fail to be create NodeAlert: "%v". Reason: %v`,
@@ -49,7 +49,7 @@ func (op *Operator) WatchNodeAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for NodeAlert: "%v". Reason: %v`,
@@ -74,7 +74,7 @@ func (op *Operator) WatchNodeAlerts() {
  if !reflect.DeepEqual(oldAlert.Spec, newAlert.Spec) {
  if ok, err := newAlert.IsValid(); !ok {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be update NodeAlert: "%v". Reason: %v`,
@@ -85,7 +85,7 @@ func (op *Operator) WatchNodeAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, newAlert); err != nil {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for NodeAlert: "%v". Reason: %v`,
@@ -100,7 +100,7 @@ func (op *Operator) WatchNodeAlerts() {
  if alert, ok := obj.(*tapi.NodeAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete NodeAlert: "%v". Reason: %v`,
@@ -111,7 +111,7 @@ func (op *Operator) WatchNodeAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for NodeAlert: "%v". Reason: %v`,

pkg/operator/nodes.go

@@ -136,7 +136,7 @@ func (op *Operator) EnsureNode(node *apiv1.Node, old, new *tapi.NodeAlert) (err
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulSync,
  `Applied NodeAlert: "%v"`,
@@ -145,7 +145,7 @@ func (op *Operator) EnsureNode(node *apiv1.Node, old, new *tapi.NodeAlert) (err
  return
  } else {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToSync,
  `Fail to be apply NodeAlert: "%v". Reason: %v`,
@@ -169,7 +169,7 @@ func (op *Operator) EnsureNodeDeleted(node *apiv1.Node, alert *tapi.NodeAlert) (
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulDelete,
  `Deleted NodeAlert: "%v"`,
@@ -178,7 +178,7 @@ func (op *Operator) EnsureNodeDeleted(node *apiv1.Node, alert *tapi.NodeAlert) (
  return
  } else {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete NodeAlert: "%v". Reason: %v`,

pkg/operator/pod_alerts.go

@@ -38,7 +38,7 @@ func (op *Operator) WatchPodAlerts() {
  if alert, ok := obj.(*tapi.PodAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToCreate,
  `Fail to be create PodAlert: "%v". Reason: %v`,
@@ -49,7 +49,7 @@ func (op *Operator) WatchPodAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for PodAlert: "%v". Reason: %v`,
@@ -74,7 +74,7 @@ func (op *Operator) WatchPodAlerts() {
  if !reflect.DeepEqual(oldAlert.Spec, newAlert.Spec) {
  if ok, err := newAlert.IsValid(); !ok {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be update PodAlert: "%v". Reason: %v`,
@@ -85,7 +85,7 @@ func (op *Operator) WatchPodAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, newAlert); err != nil {
  op.recorder.Eventf(
- newAlert,
+ newAlert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for PodAlert: "%v". Reason: %v`,
@@ -100,7 +100,7 @@ func (op *Operator) WatchPodAlerts() {
  if alert, ok := obj.(*tapi.PodAlert); ok {
  if ok, err := alert.IsValid(); !ok {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete PodAlert: "%v". Reason: %v`,
@@ -111,7 +111,7 @@ func (op *Operator) WatchPodAlerts() {
  }
  if err := util.CheckNotifiers(op.KubeClient, alert); err != nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonBadNotifier,
  `Bad notifier config for PodAlert: "%v". Reason: %v`,

pkg/operator/pods.go

@@ -146,7 +146,7 @@ func (op *Operator) EnsurePod(pod *apiv1.Pod, old, new *tapi.PodAlert) (err erro
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulSync,
  `Applied PodAlert: "%v"`,
@@ -155,7 +155,7 @@ func (op *Operator) EnsurePod(pod *apiv1.Pod, old, new *tapi.PodAlert) (err erro
  return
  } else {
  op.recorder.Eventf(
- new,
+ new.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToSync,
  `Fail to be apply PodAlert: "%v". Reason: %v`,
@@ -179,7 +179,7 @@ func (op *Operator) EnsurePodDeleted(pod *apiv1.Pod, alert *tapi.PodAlert) (err
  defer func() {
  if err == nil {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeNormal,
  eventer.EventReasonSuccessfulDelete,
  `Deleted PodAlert: "%v"`,
@@ -188,7 +188,7 @@ func (op *Operator) EnsurePodDeleted(pod *apiv1.Pod, alert *tapi.PodAlert) (err
  return
  } else {
  op.recorder.Eventf(
- alert,
+ alert.ObjectReference(),
  apiv1.EventTypeWarning,
  eventer.EventReasonFailedToDelete,
  `Fail to be delete PodAlert: "%v". Reason: %v`,