Skip to content
This repository has been archived by the owner on Dec 9, 2020. It is now read-only.

Might just be me, but... #4

Open
femerich opened this issue Apr 19, 2013 · 12 comments
Open

Might just be me, but... #4

femerich opened this issue Apr 19, 2013 · 12 comments
Assignees
Labels
Milestone

Comments

@femerich
Copy link

I thought I'd mentioned it just in case. I added the youtube.rb to my plugins directory and added the sass file to my sass/custom file. Embedding works in my markdown files, however the bottom 1/4 of the play button is cut off.

Again - I'm totally new at this stuff, and I might just be screwing it up. Anyhoo, here's a screen shot if it helps...
Screen Shot 2013-04-19 at 2 48 14 PM

Thanks!!

@optikfluffel
Copy link
Owner

Is that thing online anywhere so I can have a closer look at it to see what happens? Does it happen in every browser?

@femerich
Copy link
Author

Not yet, but let me push it online. I'll send you a link in a sec....

On Fri, Apr 19, 2013 at 7:13 PM, Udo Kramer [email protected]:

Is that thing online anywhere so I can have a closer look at it to see
what happens? Does it happen in every browser?


Reply to this email directly or view it on GitHubhttps://issues/4#issuecomment-16694397
.

Faithe :-)

@femerich
Copy link
Author

I've only looked at Chrome and Safari. It looks the same in both. Here's
a link - http://faitheemerich.s3-website-us-east-1.amazonaws.com/about/

On Fri, Apr 19, 2013 at 7:13 PM, Udo Kramer [email protected]:

Is that thing online anywhere so I can have a closer look at it to see
what happens? Does it happen in every browser?


Reply to this email directly or view it on GitHubhttps://issues/4#issuecomment-16694397
.

Faithe :-)

@optikfluffel
Copy link
Owner

I'll have a look at it tomorrow, have to attend at a family gathering today ^^

On Apr 20, 2013, at 1:38 AM, femerich [email protected] wrote:

I've only looked at Chrome and Safari. It looks the same in both. Here's
a link - http://faitheemerich.s3-website-us-east-1.amazonaws.com/about/

On Fri, Apr 19, 2013 at 7:13 PM, Udo Kramer [email protected]:

Is that thing online anywhere so I can have a closer look at it to see
what happens? Does it happen in every browser?


Reply to this email directly or view it on GitHubhttps://issues/4#issuecomment-16694397
.

Faithe :-)

Reply to this email directly or view it on GitHub.

@ghost
Copy link

ghost commented Apr 21, 2013

👍 I too am facing this issue.

@optikfluffel
Copy link
Owner

As a hotfix both of you could try to comment out the overflow: hidden from the stylesheet to get it working untill I have a little more time to do a real fix of this problem. Please let me know if this helps for the moment.

PS: @iontech could you provide a link as well?

@pfista
Copy link

pfista commented Nov 17, 2013

That hotfix doesn't seem to be working for me. Any other suggestions?

@thuytrinh
Copy link

screen shot 2013-11-24 at 5 16 47 pm

Hi. I encountered another bug that makes the video look tiny. However, when I did comment out overflow: hidden, it's resolved. Hope you can do a real fix with this info.

@optikfluffel
Copy link
Owner

@pfista @thuytrinh has one or even both of you a link to a page where the issue occurs?

@thuytrinh
Copy link

@eduncan911
Copy link

I am having the "bottom controls" cut off as well using the plugin. You can see it here:

http://eduncan911.com/technology/bitcoins-dark-wallet-launched-today.html

I'm using the versoin as of May 1st, 2014.

Great work btw! Loved the plug-n-play nature.

@eduncan911
Copy link

I was able to tweak the sass to this to show the bottom of the youtube player:

.embed-video-container {
  position: relative;
  padding-bottom: 56.25%; /* 16/9 ratio */
  padding-top: 30px; /* IE6 workaround*/
  height: 0;
  /* overflow: hidden; */
  margin-bottom: 3.5em;

  iframe, object, embed {
    position: absolute;
    top: 0;
    left: 0;
    width: 100%;
    height: 100%;
    border: 0;
  }
}

I basically got rid of the overflow: hidden, which gave it a weird margin so I had to increase the margin-bottom as well.

I have padding: 0 because of my design that embedded other iframes with borders - I just needed to remove the border for this sweet plugin.

Thanks!

@optikfluffel optikfluffel added this to the 1.0 milestone Aug 18, 2014
@optikfluffel optikfluffel self-assigned this Aug 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants