Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - Unable to see toggle menu icon for module actions with default theme creator template #2635

Closed
thabaum opened this issue Mar 4, 2023 · 1 comment · Fixed by #2628
Closed

Comments

@thabaum
Copy link
Contributor

thabaum commented Mar 4, 2023

Unable to see toggle menu icon for module actions with default theme creator template.

Issue is with color, I will submit a PR that removes color so it can be set only if needed. Default theme has white background so it should go with the text color... regardless.

@thabaum
Copy link
Contributor Author

thabaum commented Mar 5, 2023

I found more issues with dark/light themes. I will submit another commit to my PR for review. I can break them up however once everyone gets a chance to review.

I am going to add this css to the template and remove the other change as this should cure all:

.div main {
    color: black;
    filter: invert(1);
    mix-blend-mode: difference;
}

This will set default color of text to black since there is a default white background. If you change the color of the background the color of the text in the "Main" div (after the navigation menu) and will give an idea to help anyone trying to create themes that can change colors and still see everything inverted to the background color.

sbwalker added a commit that referenced this issue Mar 5, 2023
Fixes #2627 #2631 #2630 #2629 #2632  #2635 - Dev Branch Module and Theme Template Issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant