Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Translation failure in Oqtane.Client\Modules\Admin\Themes\Index.razor #4180

Closed
marceloatoledo opened this issue Apr 23, 2024 · 1 comment
Closed

[BUG] Translation failure in Oqtane.Client\Modules\Admin\Themes\Index.razor #4180

marceloatoledo opened this issue Apr 23, 2024 · 1 comment

Comments

@marceloatoledo
Copy link

marceloatoledo commented Apr 23, 2024 •
edited
Loading

Oqtane Info
Version - 5.1.1

Describe the bug
In the Oqtane.Client\Modules\Admin\Themes\Index.razor file, the "Text" property is missing from the ActionLink:
This causes translation to other languages to fail

ActionLink Action="Edit" Parameters="@($"id=" + context.ThemeId.ToString())" ResourceKey="EditTheme"

image

Expected Behavior
For the Edit button to be translated

ActionLink Action="Edit" Text="Edit" Parameters="@($"id=" + context.ThemeId.ToString())" ResourceKey="EditTheme"

image

Steps To Reproduce
Install other languages and in the language bar switch to anything other than English
leigh-pointer added a commit to leigh-pointer/oqtane.framework.fork that referenced this issue Apr 23, 2024
@leigh-pointer
Parameters Missing fix for oqtane#4180 oqtane#4182
062821d
@sbwalker
Copy link
Member

sbwalker commented Apr 23, 2024 •
edited
Loading

resolved by #4184

sbwalker added a commit that referenced this issue Apr 23, 2024
@sbwalker
Merge pull request #4184 from leigh-pointer/ParamsLang
25daa34 
Parameters Missing fix for #4180 #4182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbwalker @marceloatoledo