Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ModuleCreator template for External (Partial, Code-Behind) #1064

Closed
wants to merge 3 commits into from
Closed

Added ModuleCreator template for External (Partial, Code-Behind) #1064

wants to merge 3 commits into from

Conversation

Jayson-Furr
Copy link
Contributor

I have added a partial/code-behind copy of the external template. I have thought about creating a new module creator to generate multiple entities and their respective services based on a list, separate from the module name, specified in the creator. Does this sound like a good idea? Or, are modules based on single entity by design?

@dnfadmin
Copy link

dnfadmin commented Jan 18, 2021

CLA assistant check
All CLA requirements met.

@sbwalker
Copy link
Member

sbwalker commented Jan 18, 2021

@Jayson-Furr the purpose of the Module Creator in the framework is to provide developers with a basic functional starting point for module development - so the fewer number of options the better or else it becomes confusing and defeats the intended purpose ( some would argue that even having 2 templates - Internal and External - is too confusing ). In addition, each new template requires ongoing maintenance as the framework is improved over time. My opinion is that it would be awesome to have a more advanced Module Creator... but it should not be in the core framework. It should be created as a custom module that can be installed through Module Management similar to the Blog module.

@PavelVsl
Copy link
Contributor

PavelVsl commented Jan 19, 2021

The best solution would be to create a standard dotnet new template
https://docs.microsoft.com/en-us/dotnet/core/tutorials/cli-templates-create-project-template.

@sbwalker
Copy link
Member

I agree that support via the .NET CLI or even a custom Oqtane CLI ( ie. "oqtane new ..." ) would be a great addition to the project.

…d page was deleted. I also added HasNavigationChildren beside HasChildren to better support menus when you dont want the child pages visible in the menu. This will allow a page to have non-navigation children and not show the caret / chevron. The naming may need to change over time?
@Jayson-Furr
Copy link
Contributor Author

I think the CLI would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants