Make ActiveDatabase setter public #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two cases where we need to override the active database: Unit Testing and added GraphQL. In both of these cases, we have a database context that is in a different scope than the automatically assigned active database during normal Oqtane startup. Our work-around has been to make this setter public. Unless there is a better solution to our cases, I feel this change would be useful for others as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two cases where we need to override the active database: Unit Testing and added GraphQL. In both of these cases, we have a database context that is in a different scope than the automatically assigned active database during normal Oqtane startup. Our work-around has been to make this setter public. Unless there is a better solution to our cases, I feel this change would be useful for others as well.