File Extension management - site wide. Fix for #3493

[leigh-pointer]

I have added to the site settings file extension management. The Constants remain for backward compatibility.
If the extensions are not updated then the Constant will be used.

[sbwalker]

@leigh-pointer one observation... in razor components you do not need to call SettingService.GetSiteSettingsAsync() in order to get Site Settings - they already exist in the PageState.Site.Settings property.

[sbwalker]

@leigh-pointer one other observation... the logic for using FileManager was very simple for developers in the past:

<FileManager FileId="@_logofileid" Filter="@Constants.ImageFiles" @ref="_logofilemanager" />

With the addition of a property to the Site model it could be:

<FileManager FileId="@_logofileid" Filter="@PageState.Site.ImageFiles" @ref="_logofilemanager" />

The ImageFiles property would be read only and would utilize the Site.Settings property internally to get the value.

This eliminates the need for developers to have to figure out how to get the value from Settings and would greatly simplify the code.

[leigh-pointer]

@sbwalker i was wondering if there was a better way! Ok! I will action it!

[leigh-pointer]

@sbwalker Fixed it

[sbwalker]

@leigh-pointer this looks good. There is only 1 remaining item:

When dealing with Settings it is very important to set the IsPrivate property properly:

settings = SettingService.SetSetting(settings, "ImageFiles", _ImageFiles, true);

The last parameter in this line of code is set to "true" which says that the ImageFiles setting is private. This means that unless the user is logged in as a site administrator (or host) this setting will be filtered from the Settings collection which is returned to the user. I do not believe this is the intended behavior, as this setting is used in the FileManager which is utilized in many module components which do not require the user to be an admin (ie. user profile, etc...). So I believe the IsPrivate property should be set to False.

To provide further clarification:
IsPrivate = false - return the setting so that it can be used in client-side scenarios
IsPrivate = true - filter this setting so that it is not available in client-side scenarios - UNLESS the user is an admin

[leigh-pointer]

@sbwalker that is already being set. Settings are only saved from the Site component.

[sbwalker]

@leigh-pointer you are not understanding the behavior of the IsPrivate property. It has nothing to do with where settings are saved... it has to do with where settings are read. As an example, if you are a regular user and you browse to your user profile so that you can upload a photo... this uses the FileManager component. The FileManager component uses the ImageFiles setting to set the list of allowable file extensions which a user can upload. In this context (non-Admin) the ImageFiles setting will NOT exist in the PageSettings.Site.Settings collection. This is because it was created as a Private setting - which means that it should NOT be shared externally (ie. via the API). The only exception is when the user is an Administrator it will be in the collection because the Admin user is authorized to access it.