Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows page to find Custom Index page in Module from Actions Property #770

Merged

Conversation

PizzaConsole
Copy link
Contributor

@PizzaConsole PizzaConsole commented Oct 1, 2020

added after this discussion post was made: #765
This if statement just checks if the route is inside a Module, we do not need to check that anymore because the Index Page should always be displayed if we are not in the Module. if (module.ModuleId == moduleid && action != "") Which is why we set this var action = Constants.DefaultAction; Which basically the same thing that this was doing: else{module.ModuleType = typename.Replace(Constants.ActionToken, Constants.DefaultAction);}
I did test this with an External Module and the internal HtmlText Module, I did not find any errors.

@sbwalker
Copy link
Member

sbwalker commented Oct 1, 2020

see comments in #765

@sbwalker
Copy link
Member

sbwalker commented Oct 3, 2020

@PoisnFang I think there may be an issue with this PR. Oqtane supports 3 scenarios:

  1. ModuleId = "" - displays all modules ( displays Index component )
  2. ModuleId != "" && Action = "" - displays only the module specified by ModuleId ( displays Index component )
  3. ModuleId != "" && Action != "" - displays only the module specified by ModuleId ( displays component corresponding to Action )

I am concerned that scenario 2 is no longer supported in this PR

@PizzaConsole
Copy link
Contributor Author

@sbwalker What would be an example url for scenario 2 that I can use as reference?

@sbwalker
Copy link
Member

sbwalker commented Oct 3, 2020

http://localhost:44357/*/1

Note: that I am noticing a bug with the behavior which must have been caused by an earlier change. The module is supposed to be rendered in the standard theme - not the "admin" theme

@sbwalker sbwalker merged commit e934a28 into oqtane:master Oct 3, 2020
@PizzaConsole
Copy link
Contributor Author

Looks like the change, was fine. Just need to update the HtmlText Module to not use the admin theme in a different PR?

@sbwalker
Copy link
Member

sbwalker commented Oct 3, 2020

I am fixing the issue now. It is not related to the HtmlText module.

@PizzaConsole PizzaConsole deleted the flexible-index-page-in-custom-modules branch October 3, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants