fixed compatibility issue in .NET5/WebAssembly where assemblies were not being loaded into the default AppDomain, optimized service registration on WebAssembly, fixed spelling mistake for satellite assemblies constant and fixed issue in LocalizableComponent #857
Conversation
…not being loaded into the default AppDomain, optimized service registration on WebAssembly, fixed spelling mistake for satellite assemblies constant and fixed issue in LocalizableComponent
| @@ -68,7 +68,7 @@ public class Constants { | |||
| }; | |||
| public static readonly string[] InvalidFileNameEndingChars = { ".", " " }; | |||
|
|
|||
| public static readonly string StalliteAssemblyExtension = ".resources.dll"; | |||
| public static readonly string SatelliteAssemblyExtension = ".resources.dll"; | |||
| @@ -18,7 +18,7 @@ protected string Localize(string name) | |||
| { | |||
| if (!IsLocalizable) | |||
| { | |||
| return null; | |||
| return name; | |||
There was a problem hiding this comment.
For modules that have been created for Oqtane 1.x they may have used the ActionDialog control. When trying to run these modules on Oqtane 2.0 (.NET5) the modules run fine however when the ActionDialog modal popup is displayed, the buttons do not have any text. I stepped through the code and it is because the Localize() method is returning null. This appears to be a breaking change as it affects backward compatibility. I am not sure if the solution I checked in is valid - if not, then we will need some other type of solution to deal with this issue. It does seem to make sense to me that if a component is not localizable then the method should return the text which was passed in?
There was a problem hiding this comment.
Aha, I did that because you mentioned this in the PR about hating default values in localization ;)
No description provided.