A slabinfo fix, and the v1 (1.1.0) release #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freelist corruption results in the "slabinfo" module crashing. Since this is a common symptom of use-after-free bugs, we'd rather give useful information about this case. So don't crash the module. Catch the error and report corruption issues at the end. This also helps in certain cases where we are running against a live kernel, and the freelist is not corrupt, but it changed by the time we decoded the pointer. As a result, we print different messages at different times: for live systems, we say this may be transient, but for core dumps, we say it indicates a potential use-after-free bug. To do this, we have to implement a rather sketchy workaround to use the _SlabCacheHelperSlub from drgn. This is manually verified to work on 0.0.25 through 0.0.27, which are the only supported drgn versions. But, we need to work on upstream tweaks to improve the slab helpers, so we don't need to rely on the hack. Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
biger410
reviewed
Aug 28, 2024
buildrpm/python-drgn-tools.spec
Outdated
| @@ -1,7 +1,7 @@ | |||
| # Copyright (c) 2024, Oracle and/or its affiliates. | |||
| # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/ | |||
| Name: python-drgn-tools | |||
| Version: 0.9.1 | |||
| Version: 1.0.0 | |||
There was a problem hiding this comment.
Here is the main branch, so it is still 1.0.0? You will create a new branch for v1 and set version to 1.1.0 there and also change the version here to 2.0.0, right?
There was a problem hiding this comment.
No, I totally missed that. This should go to 1.1.0, I'll create the stable/v1 branch, and then on the main branch I'll bump to 2.0.0.
Signed-off-by: Stephen Brennan <[email protected]>
brenns10
force-pushed
the
v1-release-changes
branch
from
ed7dfd2
to
85e1b66
Compare
biger410
reviewed
Aug 28, 2024
| @@ -61,6 +61,9 @@ rm %{buildroot}/usr/bin/DRGN | |||
| %{_mandir}/man1/corelens.1.gz | |||
|
|
|||
| %changelog | |||
| * Tue Aug 27 2024 Stephen Brennan <[email protected]> - 1.1.0-1 | |||
There was a problem hiding this comment.
should this be 1.1.0 instead of 1.1.0-1?
There was a problem hiding this comment.
No, most RPMs have a release version appended with the hyphen, it starts at 1. If we update the packaging alone, we'll update that number.
There was a problem hiding this comment.
It comes from line 5 above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slabinfo fix was more involved than I wanted, but it works well, is compatible with drgn 0.0.25 - 0.0.27, and it actually makes the
slabinfomodule modestly faster.