ls: Add support to recursively print dentries of subdirectories #112
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
srivathsa729
force-pushed
the
dcache-depth-feature
branch
2 times, most recently
from
d98e9d1
to
e50989c
Compare
brenns10
requested changes
Oct 11, 2024
srivathsa729
force-pushed
the
dcache-depth-feature
branch
from
e50989c
to
ae2e620
Compare
brenns10
requested changes
Oct 16, 2024
There was a problem hiding this comment.
I'm sorry for not making these requests on the previous review, the PR looks great but I have two small nitpicks. Can you also take a look at the "Developer Workflow For drgn-tools" (check slack) and file the necessary Orabugs for this change too? I don't think this necessarily needs to go back to 1.x stable branch, but if you think it's worth it, that will be a second Orabug and a pull request against stable/v1 as the document states.
srivathsa729
force-pushed
the
dcache-depth-feature
branch
2 times, most recently
from
3b472b5
to
1847d8f
Compare
Currently, ls module prints the dentries of a given directory. Add support to print the dentries of its subdirectories recursively up to a specified depth. Orabug: 37188670 Signed-off-by: Srivathsa Dara <[email protected]>
srivathsa729
force-pushed
the
dcache-depth-feature
branch
from
1847d8f
to
70cd8d5
Compare
brenns10
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ls module prints the dentries of a given directory. Add support to print the dentries of its subdirectories recursively up to a specified depth.
Signed-off-by: Srivathsa Dara [email protected]