Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1 backport] Updating CI images & drgn 0.0.29 support #114

Merged
merged 3 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildrpm/python-drgn-tools.spec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ BuildRequires: python%{python3_pkgversion}-wheel

# The drgn dependency can be fulfilled by drgn with, or without, CTF support.
# However, drgn-tools is tied to specific drgn releases.
Requires: drgn >= 0.0.25, drgn < 0.0.28
Requires: drgn >= 0.0.25, drgn < 0.0.30

%global _description %{expand:
drgn-tools extends the drgn debugger with scripts & helpers developed by the
Expand Down
7 changes: 6 additions & 1 deletion drgn_tools/nvme.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,12 @@ def for_each_msi_desc(pdev: Object) -> Iterable[Object]:
# structure.
list = pdev.dev.msi.data.list

if list is not None:
# Unfortunately, some of the commits below (which switch to an xarray) have
# been backported without deleting the list_heads above. This leaves a valid
# list in these structures, but with null next/prev fields. Detect NULL
# entries here and assume that's the case, falling through to the xarray
# case.
if list is not None and list.next:
return list_for_each_entry(
"struct msi_desc", list.address_of_(), "list"
)
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
drgn>=0.0.25,<0.0.28
drgn>=0.0.25,<0.0.30
pytest<7.1
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def get_version():
description="drgn helper script repository",
long_description=long_description,
install_requires=[
"drgn>=0.0.25,<0.0.28",
"drgn>=0.0.25,<0.0.30",
],
url="https:/oracle-samples/drgn-tools",
author="Oracle Linux Sustaining Engineering Team",
Expand Down
26 changes: 13 additions & 13 deletions testing/heavyvm/images.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2023, Oracle and/or its affiliates.
# Copyright (c) 2024, Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
"""
Describes the "heavy" images used for running tests
Expand Down Expand Up @@ -37,28 +37,28 @@ def ks_name(self) -> str:
# OL9: UEK 7
ImageInfo(
9,
2,
4,
7,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL9/u1/x86_64/OracleLinux-R9-U1-x86_64-boot-uek.iso", # noqa
[],
"https://yum.oracle.com/ISOS/OracleLinux/OL9/u4/x86_64/OracleLinux-R9-U4-x86_64-boot-uek.iso", # noqa
["drgn-0.0.29-1.0.1.el9.x86_64.rpm"],
),
# OL8: UEK 6-7
ImageInfo(
8,
8,
10,
7,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL8/u7/x86_64/x86_64-boot-uek.iso", # noqa
[],
"https://yum.oracle.com/ISOS/OracleLinux/OL8/u10/x86_64/OracleLinux-R8-U10-x86_64-boot-uek.iso", # noqa
["drgn-0.0.29-1.0.1.el8.x86_64.rpm"],
),
ImageInfo(
8,
8,
10,
6,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL8/u7/x86_64/x86_64-boot-uek.iso", # noqa
[],
"https://yum.oracle.com/ISOS/OracleLinux/OL8/u10/x86_64/OracleLinux-R8-U10-x86_64-boot-uek.iso", # noqa
["drgn-0.0.29-1.0.1.el8.x86_64.rpm"],
),
# OL7: UEK 4-6
ImageInfo(
Expand All @@ -67,23 +67,23 @@ def ks_name(self) -> str:
6,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL7/u9/x86_64/x86_64-boot-uek.iso", # noqa
["drgn-0.0.25-1.0.2.el7.x86_64.rpm"],
["drgn-0.0.29-1.0.1.el7.x86_64.rpm"],
),
ImageInfo(
7,
9,
5,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL7/u9/x86_64/x86_64-boot-uek.iso", # noqa
["drgn-0.0.25-1.0.2.el7.x86_64.rpm"],
["drgn-0.0.29-1.0.1.el7.x86_64.rpm"],
),
ImageInfo(
7,
9,
4,
"x86_64",
"https://yum.oracle.com/ISOS/OracleLinux/OL7/u9/x86_64/x86_64-boot-uek.iso", # noqa
["drgn-0.0.25-1.0.2.el7.x86_64.rpm"],
["drgn-0.0.29-1.0.1.el7.x86_64.rpm"],
),
]
NAME_TO_CONFIGURATION = {i.name: i for i in CONFIGURATIONS}
5 changes: 1 addition & 4 deletions testing/heavyvm/imgbuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,7 @@ def run_post_install(ctx: Context) -> None:
# Starting in OL9, it looks like fio engines are packaged separately
install_packages.append("fio-engine-libaio")

# Install drgn either from Yum repo (OL8+, or from RPMs hosted on kickstart
# server)
if ctx.image_info.ol >= 8:
install_packages.append("drgn")
# Install drgn from RPMs hosted on kickstart server
for filename in ctx.image_info.rpms:
install_packages.append(ctx.ks_srv.url_for(Path(filename).absolute()))

Expand Down
Loading