-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too heavyweight org.graalvm.shadowed.icu4j #8889
Comments
A quick investigation shows it is only needed for one method in ICU4J: Do you need this to be backported to 23.1.x, or is it enough to do this for 24.1 only? |
Suggested fix: #8908. Let me know if you want to test this before merging @JaroslavTulach. |
Hello Andreas. Thanks for the #8908 fix, it looks good.
Yup,
We are trying to stay with the latest Truffle (but LTS JDK - e.g. 21), so having the fix in latest Truffle release is good enough for Enso. |
ok, so I assume this does not need to be backported, since you can use the latest version on LTS JDK. good. |
Describe GraalVM and your environment :
java -Xinternalversion
:Have you verified this issue still happens when using the latest snapshot?
Confirmed by a discussion on slack
Describe the issue
I am trying to find a minimal JDK to execute Enso programming language and environment on, I am using
jlink
. I am trying to get things down as much as I can, but Graal.js seems to needjava.desktop
! (via a transitive dependency thruregex
):E.g.
org.graalvm.js
needscom.oracle.truffle.regex
and that one needsorg.graalvm.shadowed.icu4j
and that one needsjava.desktop
.I assume the
java.desktop
dependency isn't necessary - maybe it can be made optional... can such a change be made in your build?Steps to reproduce the issue
I am generating the minimal JDK as:
and then I'd like to invoke Graal.js and its components on the generated JVM. It fails with
java.lang.module.FindException
as shown above.Expected behavior
java.desktop
is a huge module and it shouldn't be needed for running Graal.js - having that fixed would allow using Graal.js & co. in headless JDKs withoutjava.desktop
& co. modules.Additional context
I have discovered this problem while working on:
The text was updated successfully, but these errors were encountered: