Driver signature + improvements #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align all io functions documentation Add tests
|
Test on postgis added also |
SPalominos
suggested changes
Jun 8, 2020
h2gis-functions/src/main/java/org/h2gis/functions/io/asc/AscRead.java
Outdated
Show resolved
Hide resolved
h2gis-functions/src/main/java/org/h2gis/functions/io/asc/AscRead.java
Outdated
Show resolved
Hide resolved
h2gis-functions/src/main/java/org/h2gis/functions/io/asc/AscReaderDriver.java
Outdated
Show resolved
Hide resolved
| } | ||
| else if(FileUtil.isExtensionWellFormated(fileName, "gz")) { | ||
| if(deleteFiles){ | ||
| Files.deleteIfExists(fileName.toPath()); |
| } | ||
| }else if(FileUtil.isExtensionWellFormated(fileName, "zip")) { | ||
| if(deleteFiles){ | ||
| Files.deleteIfExists(fileName.toPath()); |
h2gis-functions/src/main/java/org/h2gis/functions/io/tsv/TSVDriverFunction.java
Outdated
Show resolved
Hide resolved
h2gis-functions/src/main/java/org/h2gis/functions/io/tsv/TSVDriverFunction.java
Outdated
Show resolved
Hide resolved
h2gis-functions/src/main/java/org/h2gis/functions/io/tsv/TSVDriverFunction.java
Outdated
Show resolved
Hide resolved
SPalominos
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the signature of all drivers.
It adds also support to write gz and zip file and red gz file for the drivers (geojson, osm, tsv, kml, json, csv) .see #1035
It fixes the ascii driver options see #1046
Delete option is also added on write driver. See #1036