Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Orbit browser version problems #210

Closed
haadcode opened this issue Dec 13, 2016 · 14 comments
Closed

Orbit browser version problems #210

haadcode opened this issue Dec 13, 2016 · 14 comments

Comments

@haadcode
Copy link
Member

Report bugs with the browser version here.

@dignifiedquire
Copy link
Contributor

dignifiedquire commented Dec 13, 2016

version: https://ipfs.io/ipfs/QmZkHVcXTffZQ9FxCR175wcGXtuaaejfHovQCLegYeD3qx/

Drag and drop fails:

screen shot 2016-12-13 at 19 26 02

No messages are being loaded:

screen shot 2016-12-13 at 19 28 03

@haadcode haadcode added the bug label Dec 13, 2016
@haadcode
Copy link
Member Author

screen shot 2016-12-13 at 19 30 51

screen shot 2016-12-13 at 19 30 56

@haadcode
Copy link
Member Author

One more new one:
screen shot 2016-12-14 at 01 32 12

@dignifiedquire
Copy link
Contributor

Reload is loosing the history. Even though I had a pretty long history, after a simple reload the history is empty (same channel, same username). The loading indicator is running though.

@dignifiedquire
Copy link
Contributor

screen shot 2016-12-14 at 18 45 56

@haadcode
Copy link
Member Author

I'm also losing history on Firefox but not in chrome. @dignifiedquire can you try with both?

@dignifiedquire
Copy link
Contributor

will try firefox later, but definitely seeing it in chrome

@dignifiedquire
Copy link
Contributor

Floodsub error: libp2p/js-libp2p-floodsub#11
screen shot 2016-12-14 at 16 22 07

@dignifiedquire
Copy link
Contributor

dignifiedquire commented Dec 15, 2016

There is a new build, with master + this bitswap branch: https:/ipfs/js-ipfs-bitswap/tree/new which makes things really nice https://ipfs.io/ipfs/QmXi4w3S3DqcbESA28yYw63MWNhfs3oUK8b8FSfxjb6N1S

Things are faster and stabler even with > 5 peers now.

@haadcode
Copy link
Member Author

Chrome doesn't play videos but throws an error related to "SourceBuffer". No idea why as this used to work and the code hasn't been touched. Could be a Chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=651904.

Firefox plays frags_bunny.mp4 still fine :)

@dignifiedquire
Copy link
Contributor

This is the relevant PR ipfs/js-ipfs-bitswap#83

@victorb
Copy link

victorb commented Dec 16, 2016 via email

@dignifiedquire
Copy link
Contributor

dignifiedquire commented Dec 16, 2016

I tracked the history loading bug a bit more, and it seems that the ipfs-log is corrupted somehow. For example one state in https:/haadcode/orbit-db-store/blob/master/src/Store.js#L56 for merged is

[
  {
    "hash": "QmQW8x8N39iRZ8KA6UesUkvhYXJTBEAZX7uirXU9mU1jW9",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmTFRa2XRbRrRS8vegx6XEbSDXziVN7NZXhf4w56g1Z2y7",
      "meta": {
        "ts": 1481903123114
      }
    },
    "next": []
  },
  {
    "hash": "Qmf7ByHNzK9ucPfRmfBmWgt57qsJJneV9bvQXTo9TZ54pD",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmQnwJVNXXqpfQ8YFKkrJdBWC8J7eV4x8uS8cy5W9CDvz1",
      "meta": {
        "ts": 1481903482746
      }
    },
    "next": [
      "QmQW8x8N39iRZ8KA6UesUkvhYXJTBEAZX7uirXU9mU1jW9"
    ]
  },
  {
    "hash": "QmPZRCHb5YZPH4tt9XGEJiBfhqMSzCtaCT6QtR2MvWg6hJ",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmY5RsuxCivuwkhXZ7BWwjaTNH7ZjcaoGAuhXJQqWdYYAk",
      "meta": {
        "ts": 1481903489122
      }
    },
    "next": [
      "Qmf7ByHNzK9ucPfRmfBmWgt57qsJJneV9bvQXTo9TZ54pD"
    ]
  },
  {
    "hash": "QmQ2D7ukrwAkGZFYSswV2vhZD2NNZggyYg9XjDwmfoDxf5",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "Qmd8ANPigXwLUdVF7NDdvyZaLRHSquTBZwdmmADdwjvhVN",
      "meta": {
        "ts": 1481903490713
      }
    },
    "next": [
      "QmPZRCHb5YZPH4tt9XGEJiBfhqMSzCtaCT6QtR2MvWg6hJ"
    ]
  },
  {
    "hash": "QmfXHmjWrtNvcWBNPM17ixadXSiKrYqiVSddgfctK5jktH",
    "payload": {
      "op": "ADD",
      "key": null,
      "value": "QmYNKikyQEK3GHTbEMqngnABbQMKv9LPP7TJGmnrppGTm8",
      "meta": {
        "ts": 1481903544102
      }
    },
    "next": [
      "QmQ2D7ukrwAkGZFYSswV2vhZD2NNZggyYg9XjDwmfoDxf5"
    ]
  }
]

Where the important part is the empty next of the first item. But before the reload the (visual) history was much longer and there where items before the first item.

@haadcode
Copy link
Member Author

Most of these issues should now be fixed in master. Specifically the problems related to the messages loading are now fixed.

I'm going to close this one in order to have more granular issues for each specific bug in the future. Please open new issues as you come across bugs.

Thank you everyone for reporting the issues and participating in testing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants