Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor improvements #1052

Merged
merged 4 commits into from
Feb 15, 2021
Merged

docs: minor improvements #1052

merged 4 commits into from
Feb 15, 2021

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Feb 8, 2021

  • fix: emptyResponse description wrapping to new line
  • feat: rename "Revoke and Invalidate a Session" to reflect the most common use-case (analogous to other endpoints)

Related issue

Was quite hard to find how to logout an API client: https://ory-community.slack.com/archives/C012RJ2MQ1H/p1612778929119900

@schreddies

- fix: emptyResponse description wrapping to new line
- feat: rename "Revoke and Invalidate a Session" to reflect the most common use-case (analogous to other endpoints)
@aeneasr
Copy link
Member

aeneasr commented Feb 8, 2021

Actually merge issues :(

@zepatrik
Copy link
Member Author

zepatrik commented Feb 9, 2021

Resolved 😉

@schreddies
Copy link

@zepatrik @aeneasr Thanks!

@aeneasr
Copy link
Member

aeneasr commented Feb 9, 2021

Now, compilation fails.

# Conflicts:
#	docs/docs/reference/api.mdx
#	internal/httpclient/models/complete_self_service_login_flow_with_password_method.go
#	internal/httpclient/models/complete_self_service_recovery_flow_with_link_method.go
#	internal/httpclient/models/complete_self_service_settings_flow_with_password_method.go
#	internal/httpclient/models/complete_self_service_verification_flow_with_link_method.go
#	internal/httpclient/models/create_identity.go
#	internal/httpclient/models/create_recovery_link.go
#	internal/httpclient/models/form_field.go
#	internal/httpclient/models/generic_error_payload.go
#	internal/httpclient/models/id.go
#	internal/httpclient/models/identity.go
#	internal/httpclient/models/message.go
#	internal/httpclient/models/messages.go
#	internal/httpclient/models/recovery_address.go
#	internal/httpclient/models/recovery_address_type.go
#	internal/httpclient/models/registration_flow.go
#	internal/httpclient/models/registration_flow_method_config.go
#	internal/httpclient/models/revoke_session.go
#	internal/httpclient/models/settings_via_api_response.go
#	internal/httpclient/models/state.go
#	internal/httpclient/models/traits.go
#	internal/httpclient/models/update_identity.go
#	internal/httpclient/models/verifiable_address.go
#	internal/httpclient/models/verifiable_address_status.go
#	internal/httpclient/models/verifiable_address_type.go
#	internal/httpclient/models/verification_flow.go
#	internal/httpclient/models/version.go
@aeneasr aeneasr merged commit f0672b5 into master Feb 15, 2021
@aeneasr aeneasr deleted the improve-api-logout-reference-docs branch February 15, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants