Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide JSON Schema custom keyword prefix for custom logic #115

Closed
aeneasr opened this issue Nov 9, 2019 · 0 comments · Fixed by #126
Closed

Decide JSON Schema custom keyword prefix for custom logic #115

aeneasr opened this issue Nov 9, 2019 · 0 comments · Fixed by #126
Assignees
Labels
help wanted We are looking for help on this one. rfc A request for comments to discuss and share ideas.

Comments

@aeneasr
Copy link
Member

aeneasr commented Nov 9, 2019

Is your feature request related to a problem? Please describe.

Right now, all additional information for things such as "this is the email address to log in", is express in the json schema as:

{
  "hive": {
    "credentials": {
      "password": {
        "identifier": true
      }
    }
  }
}

Describe the solution you'd like

While (a) hive was renamed to "kratos", we might also want a more unique name, potentially using a FQDN such as ory.sh/kratos.

Describe alternatives you've considered

  • ory.kratos
  • ory\.sh.kratos
  • ory\.sh/kratos
  • ory-sh

Additional context

Because both . (sjson library syntax for separating paths) and / (JSON Pointer syntax) are reserved, the FQDN might get a bit tricky. It is however the best approach to a unique keyword name.

@aeneasr aeneasr added help wanted We are looking for help on this one. rfc A request for comments to discuss and share ideas. labels Nov 9, 2019
@aeneasr aeneasr added this to the v0.0.1 milestone Nov 9, 2019
@aeneasr aeneasr self-assigned this Nov 9, 2019
aeneasr added a commit that referenced this issue Nov 22, 2019
aeneasr added a commit that referenced this issue Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We are looking for help on this one. rfc A request for comments to discuss and share ideas.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant