Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Docker file links #1182

Merged
merged 1 commit into from
Mar 29, 2021
Merged

docs: Docker file links #1182

merged 1 commit into from
Mar 29, 2021

Conversation

johanforssell
Copy link
Contributor

Proposed changes

The Quickstart documentation have broken links in then, this fixes them.

The file .kratos.yml have changed name to kratos.yml and the lines references have changed.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. [...]
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2021

CLA assistant check
All committers have signed the CLA.

@johanforssell johanforssell changed the title Updated links into kratos.yml Ready for merge after updated links into kratos.yml Mar 29, 2021
@johanforssell johanforssell changed the title Ready for merge after updated links into kratos.yml Ready for merge after updated links to kratos.yml Mar 29, 2021
@johanforssell johanforssell changed the title Ready for merge after updated links to kratos.yml docs: Docker file links Mar 29, 2021
@aeneasr
Copy link
Member

aeneasr commented Mar 29, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@johanforssell
Copy link
Contributor Author

Thanks for the input @aeneasr, I just realised that I was not thorough enough.

I've now gone over the repo with find-replace and changed all references from email-password/.kratos.yml to email-password/kratos.yml.

@aeneasr
Copy link
Member

aeneasr commented Mar 29, 2021

Thank you!

@aeneasr aeneasr merged commit 4d9b6a3 into ory:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants