-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seprate out login & registeration POST hooks #149
Comments
yindia
changed the title
Seprate out login & registeration hooks
Seprate out login & registeration POST hooks
Dec 11, 2019
one solution can be this
Default registry hook only have common hooks like redirect and sessionIssuer |
@evalsocket can I grab this one? Seems like small enough issue to start with :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In current Implementation we are using common post hooks for login & registration. in #139 we face same issue where we have to implement POST hook for only login not for registration. Currently we use a blank
ExecuteRegistrationPostHook
but that is extra ideally we have to handle it separatelyDescribe the solution you'd like
each hook should be handled individually. registry_default_login.go
instead of using the
postHook
interface here, we should just iterate over[]interface
which has all of the hooks, and then do a type assertionDescribe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: