Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take field order from schema #205

Merged
merged 9 commits into from
Jan 30, 2020
Merged

Take field order from schema #205

merged 9 commits into from
Jan 30, 2020

Conversation

zepatrik
Copy link
Member

Related issue

closes #176

Proposed changes

Forms will from now on be ordered according to the order of the keys in the traits schema.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@zepatrik
u
e19bef3
@zepatrik
Merge branch 'master' into take-field-order-from-schema
7941857 
# Conflicts:
#	selfservice/flow/profile/handler.go
#	selfservice/flow/profile/handler_test.go
@zepatrik
u
ac49e33
@zepatrik
add test
cd72e7c
@aeneasr
Copy link
Member

aeneasr commented Jan 30, 2020

@zepatrik tests failing, please set up circleci notifications :)

zepatrik and others added 4 commits January 30, 2020 17:20
@zepatrik
u
7d95fc0
@aeneasr
Update SDK
14c9072
@zepatrik
Merge branch 'master' into take-field-order-from-schema
6679bfe 
# Conflicts:
#	docs/api.swagger.json
#	internal/httpclient/models/complete_self_service_browser_profile_management_flow_payload.go
#	internal/httpclient/models/credentials_type.go
#	internal/httpclient/models/error.go
#	internal/httpclient/models/generic_error_payload.go
#	internal/httpclient/models/identity.go
#	internal/httpclient/models/registration_request.go
#	internal/httpclient/models/registration_request_method_config.go
#	internal/httpclient/models/session.go
#	internal/httpclient/models/traits.go
@aeneasr
Update SDK
a77347f
@aeneasr aeneasr merged commit a880f0d into master Jan 30, 2020
@aeneasr aeneasr deleted the take-field-order-from-schema branch February 10, 2020 14:00
@zepatrik zepatrik mentioned this pull request Apr 16, 2021
Closed
@joshlevinson joshlevinson mentioned this pull request Jan 24, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order registration/login form fields according to schema
2 participants
@zepatrik @aeneasr