Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add graceful shutdown to courier handler #296

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

Gibheer
Copy link
Contributor

@Gibheer Gibheer commented Mar 17, 2020

Courier would not stop with the provided Background handler.
This changes the methods of Courier so that the graceful package can be
used in the same way as the http endpoints can be used.

Related issue

#295
@aeneasr

Proposed changes

This adapts the API of courier to match the API of http servers and therefore allows the usage of graceful.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Courier would not stop with the provided Background handler.
This changes the methods of Courier so that the graceful package can be
used in the same way as the http endpoints can be used.
@CLAassistant
Copy link

CLAassistant commented Mar 17, 2020

CLA assistant check
All committers have signed the CLA.

When changing the API of courier, the test was missed.
@aeneasr
Copy link
Member

aeneasr commented Mar 17, 2020

Awesome, thank you!

@aeneasr aeneasr merged commit 235d784 into ory:master Mar 17, 2020
aeneasr pushed a commit that referenced this pull request Apr 7, 2020
Courier would not stop with the provided Background handler.
This changes the methods of Courier so that the graceful package can be
used in the same way as the http endpoints can be used.

Closes #295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants