Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sign-in-with-github-google-facebook-linkedin.mdx #422

Merged
merged 1 commit into from
May 19, 2020

Conversation

origandrew
Copy link
Contributor

@origandrew origandrew commented May 18, 2020

There is no email_primary in claims, and the selfservice strategy is currently using claims.email. I'm not sure if the docs are ahead of the code.

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

There is no email_primary in claims, and the selfservice strategy is currently using claims.email. I'm not sure if the docs are ahead of the code.
@CLAassistant
Copy link

CLAassistant commented May 18, 2020

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented May 19, 2020

No, you are right - this is a typo! Thanks!

1 similar comment
@aeneasr
Copy link
Member

aeneasr commented May 19, 2020

No, you are right - this is a typo! Thanks!

@aeneasr aeneasr merged commit 58f7e15 into ory:master May 19, 2020
aeneasr added a commit that referenced this pull request May 19, 2020
There is no email_primary in claims, and the selfservice strategy is currently using claims.email.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants