docs: add guide for SSO via Google #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aeneasr
reviewed
May 19, 2020
| { | ||
| identity: { | ||
| traits: { | ||
| email: claims.email |
There was a problem hiding this comment.
It probably makes sense to copy this section from Github: https:/ory/kratos/pull/424/files#diff-5beaed0e278de0cfec10f48986724b53R63-R76
There was a problem hiding this comment.
@aeneasr do you mean the comment about verified email address? Would it be relevant for google as well?
There was a problem hiding this comment.
Yes it is also relevant for Google!
docs/docs/guides/sign-in-with-github-google-facebook-linkedin.mdx
Outdated
Show resolved
Hide resolved
docs/docs/guides/sign-in-with-github-google-facebook-linkedin.mdx
Outdated
Show resolved
Hide resolved
@aeneasr commented: > This should work in future versions as well so we don't need to add this here :) Co-authored-by: hackerman <[email protected]>
Co-authored-by: hackerman <[email protected]>
|
Thank you, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
@aeneasr there is no issue I believe for this specific item but a guide for Google should be good to have.
Proposed changes
This PR adds instructions on how to setup SSO via Google.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments