-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GitLab as OIDC Provider #518
Comments
aeneasr
added a commit
that referenced
this issue
Oct 13, 2020
Closes #518 Co-authored-by: hackerman <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to GitLab's documentation
I first attempted to integrate with GitLab using the generic oidc provider like so:
with oidc.gitlab.jsonnet containing
Without making the additional call to gitlab.com/oauth/userinfo, claims doesn't contain the email and therefore no row is added to the
identities
table.I'll open a draft pull request shortly with what I was able to get working. But I'm wondering if I'm missing an existing feature of kratos that would support this. The only alternative I can think of would be to use an http mapper_url and make the call in that route before responding.
If this could be a common use-case, should an additional field be added to the provider schema. Something like
user_info_url
which would contain the url used to fetch the full claims?Related Open Issues in GitLab:
The text was updated successfully, but these errors were encountered: