Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create system errors on duplicate credentials when linking oidc providers #694

Closed
aeneasr opened this issue Sep 8, 2020 · 1 comment
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Sep 8, 2020

Describe the bug

Currently, linking a oidc profile with an account where the oidc profile has already been linked to another account will result in a system error.

Reproducing the bug

  1. Sign up a new identity using e.g. GitHub (idA)
  2. Sign up another identity using e.g. password (idB) and go to settings page
  3. Link the already used GitHub profile from idA to idB

image

Expected behavior

This should not result in a system error but instead in a validation error.

Environment

  • Version: all

Additional context

Add any other context about the problem here.

@aeneasr aeneasr added the bug Something is not working. label Sep 8, 2020
@aeneasr aeneasr added this to the v0.7.0-alpha.1 milestone Sep 8, 2020
@lmcl90
Copy link
Contributor

lmcl90 commented Jan 14, 2021

It tried to create a duplicated identifier, not a credential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants