Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set samesite attribute to lax if in dev mode #824

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix: set samesite attribute to lax if in dev mode #824

merged 1 commit into from
Nov 16, 2020

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Nov 13, 2020

Related issue

#821

Proposed changes

This PR will set the SameSite attribute to Lax if ran in dev mode.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

This lacks tests. Help with those would be appreciated.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aeneasr
aeneasr approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit 91d6698 into ory:master Nov 16, 2020
@aeneasr aeneasr added the corp/m4 Up for M4 at Ory Corp. label Dec 8, 2020
@rauno56 rauno56 deleted the fix/lax-if-dev branch June 16, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
corp/m4 Up for M4 at Ory Corp.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rauno56 @CLAassistant @aeneasr