Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make cli commands consumable in Ory Cloud #926

Merged
merged 2 commits into from
Dec 20, 2020
Merged

feat: make cli commands consumable in Ory Cloud #926

merged 2 commits into from
Dec 20, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 19, 2020

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@aeneasr
Copy link
Member Author

aeneasr commented Dec 19, 2020

@zepatrik fyi

@aeneasr aeneasr merged commit fed790b into master Dec 20, 2020
@aeneasr aeneasr deleted the improve-identities branch December 20, 2020 15:08
@aeneasr aeneasr added corp/m4 Up for M4 at Ory Corp. feat New feature or request. labels Dec 20, 2020
zepatrik
zepatrik reviewed Dec 21, 2020
View reviewed changes
docs/sidebar.json
@@ -50,6 +50,31 @@
"cli/kratos-version"
]
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here two times now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably another failure in the automation

zepatrik
zepatrik reviewed Dec 21, 2020
View reviewed changes
go.mod
@@ -7,12 +7,14 @@ replace github.com/markbates/pkger => github.com/falafeljan/pkger v0.17.1-0.2020

replace gopkg.in/DataDog/dd-trace-go.v1 => gopkg.in/DataDog/dd-trace-go.v1 v1.27.1-0.20201005154917-54b73b3e126a

// Use the internal httpclient which can be generated in this codebase but mark it as the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big brain

@zepatrik
Copy link
Member

When I run make sdk now it deletes the go.mod but does not create a new one. Also it was a pain to upgrade swagger, I first had to remove the rewrite of the client and then change the version number to some release that exists. Can you maybe have a look on that @aeneasr ? Next week is fine though, I thought I'd debug the sidebar cli docs generation issue, but won't do that this week now.

@aeneasr
Copy link
Member Author

aeneasr commented Dec 31, 2020

Yeah I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik left review comments

Assignees
No one assigned
Labels
corp/m4 Up for M4 at Ory Corp. feat New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeneasr @zepatrik