Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make form fields an array #197

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Make form fields an array #197

merged 3 commits into from
Jan 29, 2020

Conversation

zepatrik
Copy link
Member

Related issue

closes #186

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@zepatrik zepatrik requested a review from aeneasr January 28, 2020 15:34
@aeneasr
Copy link
Member

aeneasr commented Jan 28, 2020

build still failing :/

do you not get notified by circle?

@aeneasr aeneasr merged commit 6cb0058 into master Jan 29, 2020
@aeneasr aeneasr deleted the order-form-fields branch January 29, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormFields for Login, Registration, Profile requests should be array and not maps
2 participants
@zepatrik @aeneasr