Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fixes #467

Merged
merged 2 commits into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/docs/self-service/flows/user-login-user-registration.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,9 @@ summarized in this state diagram:
1. ORY Kratos executes Jobs defined in the **Before Login/Registration
Workflow**. If a failure occurs, the whole flow is aborted.
1. The user's browser is redirected to
`http://127.0.0.1:4455/.ory/kratos/public/self-service/browser/flows/requests/(login|registration)`
`http://127.0.0.1:4455/.ory/kratos/public/self-service/browser/flows/(login|registration)`
(the notation `(login|registration)` expresses the two possibilities of
`../self-service/browser/flows/requests/login` or
`../self-service/browser/flows/requests/registration`).
`../self-service/browser/flows/login` or `../self-service/browser/flows/registration`).
1. ORY Kratos does some internal processing (e.g. checks if a session cookie is
set, generates payloads for form fields, sets CSRF token, ...) and redirects
the user's browser to the Login UI URL which is defined using the
Expand Down Expand Up @@ -400,7 +399,7 @@ would be called via AJAX instead of making a request to
To prevent brute force, guessing, session injection, and other attacks, it is
required that cookies are working for this endpoint. The cookie set in the
initial HTTP request made to
`https://127.0.0.1:4455/.ory/kratos/public/self-service/browser/login` MUST be
`https://127.0.0.1:4455/.ory/kratos/public/self-service/browser/flows/login` MUST be
set and available when calling this endpoint!

:::info
Expand Down
2 changes: 1 addition & 1 deletion selfservice/errorx/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type errorContainerParameters struct {
// This endpoint returns the error associated with a user-facing self service errors.
//
// When accessing this endpoint through ORY Kratos' Public API, ensure that cookies are set as they are required for CSRF to work. To prevent
// token scanning attacks, the public endpoint does not return 404 status codes to prevent scanning attacks.
// token scanning attacks, the public endpoint does not return 404 status codes.
//
// More information can be found at [ORY Kratos User User Facing Error Documentation](https://www.ory.sh/docs/kratos/self-service/flows/user-facing-errors).
//
Expand Down
2 changes: 1 addition & 1 deletion selfservice/flow/login/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ type getSelfServiceBrowserLoginRequestParameters struct {
// other information.
//
// When accessing this endpoint through ORY Kratos' Public API, ensure that cookies are set as they are required for CSRF to work. To prevent
// token scanning attacks, the public endpoint does not return 404 status codes to prevent scanning attacks.
// token scanning attacks, the public endpoint does not return 404 status codes.
//
// More information can be found at [ORY Kratos User Login and User Registration Documentation](https://www.ory.sh/docs/next/kratos/self-service/flows/user-login-user-registration).
//
Expand Down
2 changes: 1 addition & 1 deletion selfservice/flow/registration/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ type getSelfServiceBrowserRegistrationRequestParameters struct {
// other information.
//
// When accessing this endpoint through ORY Kratos' Public API, ensure that cookies are set as they are required for CSRF to work. To prevent
// token scanning attacks, the public endpoint does not return 404 status codes to prevent scanning attacks.
// token scanning attacks, the public endpoint does not return 404 status codes.
//
// More information can be found at [ORY Kratos User Login and User Registration Documentation](https://www.ory.sh/docs/next/kratos/self-service/flows/user-login-user-registration).
//
Expand Down