Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings defaults does not always work in viper/viperx #169

Closed
aeneasr opened this issue Jun 30, 2020 · 1 comment
Closed

Settings defaults does not always work in viper/viperx #169

aeneasr opened this issue Jun 30, 2020 · 1 comment
Assignees
@zepatrik
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Jun 30, 2020

Describe the bug

We need a workaround like this despite the defaults being set here

To Reproduce

See above

Expected behavior

The default should be set
@aeneasr aeneasr added the bug Something is not working. label Jun 30, 2020
aeneasr added a commit to ory/kratos that referenced this issue Jul 2, 2020
@aeneasr
docs: add fixme note for viper workaround
9d24544 
See ory/x#169
aeneasr added a commit to ory/kratos that referenced this issue Jul 2, 2020
@aeneasr
docs: add fixme note for viper workaround
7c6744b 
See ory/x#169
aeneasr added a commit to ory/kratos that referenced this issue Jul 2, 2020
@aeneasr
docs: add fixme note for viper workaround
7e3eef6 
See ory/x#169
@aeneasr
Copy link
Member Author

aeneasr commented Jan 3, 2021

This is resolved by using koanf

@aeneasr aeneasr closed this as completed Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @zepatrik